Closed (outdated)
Project:
Commerce CyberSource
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
13 Sep 2011 at 21:11 UTC
Updated:
3 Jul 2020 at 21:43 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
rszrama commentedAgreed. Looks like I just hardcoded "default" and thought to come back to it later. We should add a field selection widget that lets you identify any field attached to a product type as the productCode field (let's assume there will only be one since fields can be reused across types). We can also provide a textfield for the default value that defaults to "default".
Comment #2
mikey_p commentedHere's a first stab at this.
I changed a couple of invalid line item properties that we're invalid along with the addition for product code in a custom field:
Comment #3
mikey_p commentedRemoved a redundant comment.
Comment #4
mikey_p commentedAnother patch, this one removes the line that assigns and ID to the item, since cybersource only uses the index, not ID, and it only indexes from 0. (If item 0 is missing, it rejects, and returns an missing field error).
I don't know much about how entity_metadata_wrapper works, but I hope we can trust the Iterator and ArrayAccess to consistently sort the items, otherwise we'll have to flatten it out into a separate array and sort it before preparing the order, and remapping the response to line items will be a bit of a pain.
Comment #5
mikey_p commentedI take that back, the missing id field was causing CyberSource to return a SOAPException about java.lang.NullPointer error or something like that.
This just uses the delta since it's going to get reassigned anyway.
Comment #6
rszrama commentedThanks for your efforts on this back in the day, sorry we never carried this forward to a full release. I'm leaving the 7.x branch marked as supported to avoid error messages in the UI, but given the 8+ years that have elapsed, I'm marking all 7.x issues outdated and focusing on a feature complete integration in the 8.x branch.
Comment #7
rszrama commented