Coding Standard issues

Hi @cmsMinds ,
Thanks for patch I will review this.

Hi @cmsMinds,

</code>
your patch has applied successfully.
<code>win10@DESKTOP-VCMGGU5 MINGW64 /c/xampp/htdocs/DRUPAL CONTRIB/drup8/web/modules/contrib/commerce_banklink-2879380 (2879380-coding-standard-issues)
$ git apply -v commerce_banklink.patch
Checking patch config/schema/commerce_banklink.schema.yml...
Checking patch src/Plugin/Commerce/PaymentGateway/GenericBanklinkPaymentGateway.php...
Checking patch src/PluginForm/OffsiteRedirect/PaymentOffsiteForm.php...
Applied patch config/schema/commerce_banklink.schema.yml cleanly.
Applied patch src/Plugin/Commerce/PaymentGateway/GenericBanklinkPaymentGateway.php cleanly.
Applied patch src/PluginForm/OffsiteRedirect/PaymentOffsiteForm.php cleanly.

still I am getting error.

win10@DESKTOP-VCMGGU5 MINGW64 /c/xampp/htdocs/DRUPAL CONTRIB/drup8/web/modules/contrib
$ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig commerce_banklink-2879380/

FILE: C:\xampp\htdocs\DRUPAL CONTRIB\drup8\web\modules\contrib\commerce_banklink-2879380\commerce_banklink.info.yml
-------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------
 1 | WARNING | "core_version_requirement" property is missing in the info.yml file
 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
-------------------------------------------------------------------------------------------------------------------


FILE: C:\xampp\htdocs\DRUPAL CONTRIB\drup8\web\modules\contrib\commerce_banklink-2879380\src\Plugin\Commerce\PaymentGateway\GenericBanklinkPaymentGateway.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 5 WARNINGS AFFECTING 8 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------------
   1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
  48 | WARNING | [ ] #options values usually have to run through t() for translation
  49 | WARNING | [ ] #options values usually have to run through t() for translation
  52 | WARNING | [ ] #options values usually have to run through t() for translation
  53 | WARNING | [ ] #options values usually have to run through t() for translation
 152 | WARNING | [ ] Code after the THROW statement on line 150 cannot be executed
 209 | ERROR   | [ ] Function openssl_free_key() has been deprecated
 220 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
-------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: C:\xampp\htdocs\DRUPAL CONTRIB\drup8\web\modules\contrib\commerce_banklink-2879380\src\PluginForm\OffsiteRedirect\PaymentOffsiteForm.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
 38 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 38 | ERROR   | [ ] The array declaration extends to column 127 (the limit is 80). The array content should be split up over multiple lines
 69 | ERROR   | [ ] Function openssl_free_key() has been deprecated
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------

Time: 1.4 secs; Memory: 10MB

moving to needs work. I am working on it.
Thanks

Hi,
I have worked on this issue.
providing patch file for review.
Thanks

win10@DESKTOP-VCMGGU5 MINGW64 /c/xampp/htdocs/DRUPAL CONTRIB/drup8/web/modules/contrib
$ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig commerce_banklink-2879380/

win10@DESKTOP-VCMGGU5 MINGW64 /c/xampp/htdocs/DRUPAL CONTRIB/drup8/web/modules/contrib
$ phpcbf --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig commerce_banklink-2879380/

No fixable errors were found

Time: 683ms; Memory: 10MB

Hi,
i am reviewing the patch.
Thank you.

Hi,
Patch applied cleanly.
Thank you.