While working on #2966612: Gateway settings lost during upgrade for AcceptJS and eCheck plugin split we discovered that pre-AcceptJS users will upgrade and not have a properly configured gateway plugin. While normal QA should catch this, we should provide some sort of alert to the user during the Drupal updates process.

I'm proposing a post_update which checks all valid gateway plugins and alerts on any payment gateway with an empty "client_key"

CommentFileSizeAuthor
#3 Drupal_database_update___Site-Install.png72.04 KBmglaman
#3 2971170-3.patch4.2 KBmglaman
#2 2971170-2.patch4.24 KBmglaman

Comments

mglaman created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Active » Needs review
Issue tags: +Needs manual testing
StatusFileSize
new 2971170-2.patch4.24 KB

This adds a warning for each. Needs manual testing.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
StatusFileSize
new 2971170-3.patch4.2 KB
new Drupal_database_update___Site-Install.png72.04 KB

Instead of using messenger, just return messages in the post_update. We will have to highlight in the release notes.

  • mglaman committed 64e0d85 on 8.x-1.x 
    Issue #2971170 by mglaman: Make sure AcceptJS gateways have the...
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Fixed

  • mglaman committed c416e3e on 8.x-1.x 
    Issue #2971170: Follow up to not display error if there are no errors.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.