The ConfigurationFormTest is failing because the test is not performing the required form interactions (javascript) before submitting the new payment gateway form. The test should be changed from Functional to FunctionalJavascript so the appropriate changes can be made before submitting the form.

CommentFileSizeAuthor
#8 2914950-8.patch2.97 KBmglaman
#5 commerce_authnet-2914950-config_form_test-5.patch5.82 KBczigor

Comments

steveoliver created an issue. See original summary.

steveoliver’s picture

steveoliver commented
Status: Active » Needs review

See https://github.com/drupalcommerce/commerce_authnet/pull/3.

Build doesn't pass, but configuration test does now.

steveoliver’s picture

steveoliver commented
Title: Fix Commerce Authorize.net configuration test » Fix configuration test
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

Ugh, patch doesn't apply due to .travis.yml changes. Go figure. I can fixup in the morning.

czigor’s picture

czigor commented
Issue summary: View changes
StatusFileSize
new commerce_authnet-2914950-config_form_test-5.patch5.82 KB

The attached patch contains the changes of the PR linked in #2 and also adds config schema for the client key which has been forgotten in #2813401: Use Accept.js to ease PCI requirements..

No coding standards fixes are added, so travis will probably still complain.

czigor’s picture

czigor commented
Issue summary: View changes
czigor’s picture

czigor commented

ConfigurationFormTest is green, only the other tests are failing.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Assigned: steveoliver » Unassigned
StatusFileSize
new 2914950-8.patch2.97 KB

Attempted re-roll.

  • mglaman committed 7c998a5 on 8.x-1.x authored by czigor 
    Issue #2914950 by czigor, mglaman: Fix configuration test
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.