I did used the coder module on this module and I've got "6 critical warnings, 3 normal warnings, 23 minor warnings" with this options:
Converting 6.x modules to 7.x
Drupal Coding Standards (every developer should use)
Drupal Commenting Standards (every developer should use)
Drupal SQL Standards
Drupal Security Checks

Please review and fix.
Thx

Comments

xpete’s picture

xpete commented

with the last update i get 7 critical warnings

farhadhf’s picture

farhadhf commented

commit 67d414814fa7e902d8ae7038bc016993d16f70a7 fixed them all! :)

xpete’s picture

xpete commented

Select "Converting 6.x modules to 7.x" and "minor (most)" and you will still get 7 critical warnings about some deprecated stuff like:
"Line 9: Module .info files must now specify all loadable code files explicitly."
"Line 58: hook_access removed in favor of hook_node_access."
"For improved performance, it is highly recommended that time() is replaced with REQUEST_TIME"

farhadhf’s picture

farhadhf commented

"Line 9: Module .info files must now specify all loadable code files explicitly." : documentation says "Files containing only functions need not be listed in the .info file." This module has a .module file and a .install file and both of them only contain functions.
"Line 58: hook_access removed in favor of hook_node_access." : I didn't mean to implement hook_access! Renamed the function.

every time() function replaced with REQUEST_TIME.

Thanks

xpete’s picture

xpete commented

I guess you forgot to do the commit...

farhadhf’s picture

farhadhf commented

yes, sorry, Just committed the changes!

xpete’s picture

xpete commented
Status: Active » Closed (fixed)

looks good to me