Problem/Motivation

Commerce still requires Inline Entity Form (commerce.info.yml, composer.json), but its own forms no longer use it: order items are edited with the commerce_order_items widget. A major release is the time to drop a dependency that could not be removed in 3.x.

Remaining references:

  • OrderItemInlineForm and ProductVariationInlineForm extend IEF's EntityInlineForm and are declared as the inline_form handlers of order items and product variations.
  • The default order form display (core.entity_form_display.commerce_order.default.default.yml) still lists inline_entity_form as a module dependency, although no component uses an IEF widget.
  • IEF-aware code: CommerceCartHooks (widget options), SingleVariationWidget, and the checks on inline_entity_form_complex in commerce_order.install and commerce_product.post_update.php.
  • CommerceKernelTestBase enables the module.

Proposed resolution

  • Remove inline_entity_form from commerce.info.yml and composer.json.
  • Remove the stale dependency from the default order form display.
  • Keep the IEF integration working for sites that install IEF themselves: the inline_form handlers are only loaded by IEF, so they can stay, guarded where needed so nothing loads them without IEF.
  • Stop enabling IEF in CommerceKernelTestBase; tests that need it enable it themselves.

Remaining tasks

  • Confirm that nothing outside IEF loads the inline_form handlers, or move them so they cannot fatal without IEF.
  • Test a fresh install and the product/order forms without IEF.

User interface changes

None.

API changes

Sites and modules using IEF widgets on Commerce entities must require drupal/inline_entity_form themselves. Existing sites keep IEF installed; nothing uninstalls it.

Data model changes

None.

Comments

jsacksick created an issue.