Problem/Motivation

In orders "Payments" tab the "Add payment" action button is missing, e.g. /admin/commerce/orders/12345/payments

While it is defined in commerce_payment.links.action.yml:

entity.commerce_payment.add_form:
  route_name: entity.commerce_payment.add_form
  title: 'Add payment'
  appears_on:
    - entity.commerce_payment.collection
    - view.commerce_order_payments.page_1

and its path also works:
/admin/commerce/orders/12345/payments/add

Steps to reproduce

Visit /admin/commerce/orders/12345/payments and see no "Add payments" action button which should be visible top right typically.

Proposed resolution

  1. Write a test to check for the button (should fail)
  2. Fix the issue
  3. See the test green
  4. Release

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Describe your bug or feature request.

If a bug, provide steps to reproduce it from a clean install.

Issue fork commerce-3593531

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

anybody created an issue. See original summary.

anybody’s picture

The definition looks correct to me, but it doesn't show up. Any ideas why?

jsacksick’s picture

Do you know if your order has a NULL balance? Check that first.

mildertechnologies’s picture

Assigned: Unassigned » mildertechnologies
mildertechnologies’s picture

i am picking this one up!

jsacksick’s picture

Status: Active » Postponed (maintainer needs more info)
anybody’s picture

Status: Postponed (maintainer needs more info) » Closed (works as designed)

Thank you very much @jsacksick indeed I can confirm it shows up for other orders with a balance != 0.
No idea why it didn't work for the broken order, but with that information given I was not able to reproduce the bug. Sorry for the trouble and sorry I didn't see that condition!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.