When using PHP 8.4 (using Drupal 10.6.x and drupal/commerce 2.40.0), noticing the following PHP deprecation errors:

PHP Deprecated:  Drupal\commerce_order\Form\OrderAddForm::__construct(): Implicitly marking parameter $password_generator as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/docroot/modules/contrib/commerce/modules/order/src/Form/OrderAddForm.php on line 49

PHP Deprecated:  Drupal\commerce_order\Form\CustomerFormTrait::buildCustomerForm(): Implicitly marking parameter $order as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/docroot/modules/contrib/commerce/modules/order/src/Form/CustomerFormTrait.php on line 43

PHP Deprecated:  Drupal\commerce_order\Form\OrderReassignForm::__construct(): Implicitly marking parameter $password_generator as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/docroot/modules/contrib/commerce/modules/order/src/Form/OrderReassignForm.php on line 46

PHP Deprecated:  Drupal\commerce_order\Controller\AddressBookController::filterTypesByViewAccess(): Implicitly marking parameter $account as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/docroot/modules/contrib/commerce/modules/order/src/Controller/AddressBookController.php on line 335

(I've seen them fixed on 3.x, but needed to fix it on 2.x as we will use it until we upgrade our sites to Drupal 11, when we will finally move to Commerce 3.x. Figured out that I can add it here for people still using 2.x)

Issue fork commerce-3593312

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andreastkdf created an issue. See original summary.

andreastkdf’s picture

andreastkdf commented
Issue summary: View changes

andreastkdf opened merge request !694

andreastkdf’s picture

andreastkdf commented
Status: Active » Needs review
andreastkdf’s picture

andreastkdf commented
Issue summary: View changes

jsacksick made their first commit to this issue’s fork.

jsacksick’s picture

jsacksick commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.