Describe your bug or feature request.

When using PHP 8.4 (using Drupal 10.6.x and drupal/commerce 2.40.0), noticing the following PHP deprecation error:

Drupal\commerce\InlineFormManager::createInstance(): Implicitly marking parameter $entity as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/docroot/modules/contrib/commerce/src/InlineFormManager.php on line 46

Issue fork commerce-3593279

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andreastkdf created an issue. See original summary.

andreastkdf’s picture

andreastkdf commented
Assigned: andreastkdf » Unassigned
Status: Active » Closed (outdated)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

andreastkdf’s picture

andreastkdf commented
Status: Closed (outdated) » Active

andreastkdf opened merge request !693

andreastkdf’s picture

andreastkdf commented
Status: Active » Needs review
andreastkdf’s picture

andreastkdf commented
Title: PHP 8.4 deprecation error » PHP 8.4 deprecation error on Drupal\commerce\InlineFormManager::createInstance()
jsacksick’s picture

jsacksick commented

8.x-2.x is no longer actively maintained, and this was fixed in 3.x already.

andreastkdf’s picture

andreastkdf commented

Thanks, jsacksick, I've seen it fixed on 3.x, but needed to fix it on 2.x as we will use it until we upgrade our sites to Drupal 11 when we will finally move to commerce 3.x.

Small deprecation fixes can't hurt, figured out that I can add it here for people still using 2.x :)

jsacksick’s picture

jsacksick commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.