All of our dependencies can now be installed on D9, so it's time to get ourselves a green build.

The current build is at https://www.drupal.org/pift-ci-job/1595614.

A number of tests are failing, probably because of path_alias. Quoting berdir in #3100913: CountryNameTokenTest update for Drupal 9:

The problem is that the kernel test *will* fail on Drupal 9.0 because we did not add the BC layer for installing path_alias there for kernel tests. So at least that part will be required, but only once the module requires 8.8.

CommentFileSizeAuthor
#8 3116756-8-fix-d9-tests.patch2.04 KBbojanz
#5 3116756-5-fix-d9-tests.patch2.05 KBbojanz
#4 3116756-3-fix-d9-tests.patch1.98 KBbojanz
#2 3116756-2-fix-d9-tests.patch878 bytesbojanz

Comments

bojanz created an issue. See original summary.

bojanz’s picture

bojanz commented
Status: Active » Needs review
StatusFileSize
new 3116756-2-fix-d9-tests.patch878 bytes

Hello, ugly hack.

Status: Needs review » Needs work

The last submitted patch, 2: 3116756-2-fix-d9-tests.patch, failed testing. View results

bojanz’s picture

bojanz commented
Title: Make the tests pass on D9 » Make the tests closer to passing on D9
Status: Needs work » Needs review
StatusFileSize
new 3116756-3-fix-d9-tests.patch1.98 KB

From 214 to 12 fails.

Let's see if we can do a few more.

Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.

This is super annoying because assertStringContainsString() doesn't exist in PhpUnit 6.

bojanz’s picture

bojanz commented
StatusFileSize
new 3116756-5-fix-d9-tests.patch2.05 KB

Aand again.

The last submitted patch, 4: 3116756-3-fix-d9-tests.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 5: 3116756-5-fix-d9-tests.patch, failed testing. View results

bojanz’s picture

bojanz commented
Status: Needs work » Needs review
StatusFileSize
new 3116756-8-fix-d9-tests.patch2.04 KB
bojanz’s picture

bojanz commented
Title: Make the tests closer to passing on D9 » Get the tests closer to passing on D9

Looks like this is as close as we'll get in this round.

  • bojanz committed 4231865 on 8.x-2.x 
    Issue #3116756 by bojanz: Get the tests closer to passing on D9
bojanz’s picture

bojanz commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.