Now that #2844963: Complete the revision implementation is in, we need to make sure the revision log message field isn't shown in Checkout (if for some reason, revisions are enabled for the customer profile type).

CommentFileSizeAuthor
#4 3061017-4-remove-log-message.patch4.15 KBbojanz
#2 3061017-2.patch821 bytesjsacksick

Comments

jsacksick created an issue. See original summary.

jsacksick’s picture

jsacksick commented
Status: Active » Needs review
StatusFileSize
new 3061017-2.patch821 bytes
bojanz’s picture

bojanz commented
Status: Needs review » Needs work

We load the form display three times, in buildInlineForm(), validateInlineForm() and submitInlineForm().
Conceptually it feels unwise to remove the field only from one of them.
So let's introduce a loadFormDisplay() helper method and do it there.
This would also help people who want to override the used form display.

bojanz’s picture

bojanz commented
Status: Needs work » Needs review
StatusFileSize
new 3061017-4-remove-log-message.patch4.15 KB

Here we go.
Also used the opportunity to clean up a few asserts, by making $this->entity have the right typehint by default.

  • bojanz committed 5cba5b9 on 8.x-2.x 
    Issue #3061017 by jsacksick, bojanz: Remove the revision_log_message...
bojanz’s picture

bojanz commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.