Problem/Motivation
Promotion conditions are executed in a consecutive manner. As soon as a condition fails the promotion will not apply. We need to allow a simplistic OR operation.
This should not be overly complex, like Rules, since complex conditions should be implemented as their own condition plugin, anyways.
Proposed resolution
Add buildConfigurationForm method to \Drupal\commerce_promotion\Plugin\Commerce\PromotionCondition\PromotionConditionBase that exposes an "AND" or "OR" operation.
Update \Drupal\commerce_promotion\Entity\Promotion::applies to support conditions which do "OR" and not immediately fail.
Remaining tasks
Do it.
Comments
Comment #2
bojanz commentedComment #4
bojanz commentedYay.