The file commerce/includes/commerce.currency.inc seems a bit outdated and the lack of numeric_code values throws errors when required and missing.

I have only reviewed currencies which are in the file and missing a numeric_code value.

The review follows the ISO 4217 standard found here https://en.wikipedia.org/wiki/ISO_4217

If a currency is no longer active per the list, then I have removed it from the file.
ARM was discontinued in 1969. Removed
MTP is actually MTL (470) and MTL has been inactive since Malta converted to Euro. Removed.
RHD is technically ZWL (932), but since the currency was abandoned in exchange for stable foreign currencies, there is no longer a local currency since 2009. Removed.

If it is active, then I assigned its numeric_code value.
AZN, GHS, MZN, RON, RSD, SRD, VEF

Comments

hkovacs created an issue. See original summary.

hkovacs’s picture

hkovacs’s picture

Issue summary: View changes

Status: Needs review » Needs work
bojanz’s picture

--- a/sites/all/modules/commerce/includes/commerce.currency.inc
+++ b/sites/all/modules/commerce/includes/commerce.currency.inc

The patch doesn't apply because it wasn't rolled from the Commerce directory.

In the future we want to regenerate the 1.x currency list from the 2.x source (CLDR, https://github.com/commerceguys/intl/tree/master/resources/currency see en.json + base.json)

bojanz’s picture

Status: Needs work » Closed (duplicate)

Closing as duplicate of #2888674: Regenerate the currency list from CLDR, since this patch was never updated.