Just like there's a default argument plugin for the current user, there should be one for the active store.
It would allow a view of products to be filtered by the active store, for example.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bojanz created an issue. See original summary.

jazzdrive3’s picture

Assigned: Unassigned » jazzdrive3
GoZ’s picture

Status: Active » Needs review
FileSize
2.1 KB
GoZ’s picture

Status: Needs review » Needs work

My bad, there is a PR for this issue : https://github.com/drupalcommerce/commerce/pull/275

jazzdrive3’s picture

Status: Needs work » Needs review

Curious what the workflow is for working on Commerce 2.x. My PR for this has been open for quite a while. https://github.com/drupalcommerce/commerce/pull/275

bojanz’s picture

I'm sorry Matt, you're the last contributor I'd want to ignore, this issue managed to fall off my radar due to our deadlines which had me chasing my own code. I'll review and commit ASAP.

mglaman credited mglaman.

mglaman’s picture

Assigned: jazzdrive3 » mglaman

Picking this up to close it out

mglaman’s picture

Uploading revised patch. Pushed changes to jazzdrive3's GitHub fork so the PR is up to date.

We need to test this, though.

mglaman’s picture

Assigned: mglaman » Unassigned
bojanz’s picture

Status: Needs review » Needs work

Right, so we need a test, and we need to remove the @file docblocks. The code itself looks good.

EDIT: Decided to merge without tests. Removed the @file docblocks, tested manually. Waiting on Travis.

  • bojanz committed 6f5e9fb on 8.x-2.x authored by jazzdrive3
    Issue #2610220 by mglaman, GoZ, bojanz, jazzdrive3: Create a views...
bojanz’s picture

Status: Needs work » Fixed

Boom! :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.