Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Just like there's a default argument plugin for the current user, there should be one for the active store.
It would allow a view of products to be filtered by the active store, for example.
Comment | File | Size | Author |
---|---|---|---|
#9 | create_a_views_argument-2610220-9.patch | 4.57 KB | mglaman |
#3 | create_a_views_argument-2610220-3.patch | 2.1 KB | GoZ |
Comments
Comment #2
jazzdrive3 CreditAttribution: jazzdrive3 at Lullabot commentedComment #3
GoZ CreditAttribution: GoZ at Centarro commentedComment #4
GoZ CreditAttribution: GoZ at Centarro commentedMy bad, there is a PR for this issue : https://github.com/drupalcommerce/commerce/pull/275
Comment #5
jazzdrive3 CreditAttribution: jazzdrive3 at Lullabot commentedCurious what the workflow is for working on Commerce 2.x. My PR for this has been open for quite a while. https://github.com/drupalcommerce/commerce/pull/275
Comment #6
bojanz CreditAttribution: bojanz at Centarro commentedI'm sorry Matt, you're the last contributor I'd want to ignore, this issue managed to fall off my radar due to our deadlines which had me chasing my own code. I'll review and commit ASAP.
Comment #8
mglamanPicking this up to close it out
Comment #9
mglamanUploading revised patch. Pushed changes to jazzdrive3's GitHub fork so the PR is up to date.
We need to test this, though.
Comment #10
mglamanComment #11
bojanz CreditAttribution: bojanz at Centarro commentedRight, so we need a test, and we need to remove the @file docblocks. The code itself looks good.
EDIT: Decided to merge without tests. Removed the @file docblocks, tested manually. Waiting on Travis.
Comment #13
bojanz CreditAttribution: bojanz at Centarro commentedBoom! :)