This is happening for line items coming from Commerce Discount which are being saved by other calls, but then subsequently overridden by an order object stored in $form_state['order'] in commerce_customer_profile_copy_validate. This function seems to have an old cached version. We think we fixed it by reloading the order at the beginning on the call. Patch to come.

CommentFileSizeAuthor
#1 commerce_customer-reload_order_for_profile_copy-2298003-1.patch768 byteschristoph

Comments

christoph’s picture

christoph commented
StatusFileSize
new commerce_customer-reload_order_for_profile_copy-2298003-1.patch768 bytes

Patch for issue above.

jsacksick’s picture

jsacksick commented
Status: Active » Needs work

You shouldn't rely on the order number to load the order, it contains the order id by default, but if you have a module that sets it to a different value, this won't work.

rszrama’s picture

rszrama commented

Tagging for http://contribkanban.com/#/board/commerce/7.x-1.x.

This is related to other issues dealing with stale objects in form states I believe.

torgospizza’s picture

torgospizza
he/him
Primary language English
Location Portland, OR
commented
Issue tags: +Commerce Sprint

Tagging for sprint, but probably a duplicate of #1804592: During AJAX form submission in checkout, the $order argument passed by the Form API is incorrect. and #2521082: Customer profile copy create empty copy if source validation fail

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Closed (duplicate)

I'm quite sure this is a duplicate of the ones @torgosPizza mentioned in #4

+++ b/modules/customer/commerce_customer.module
@@ -1350,6 +1350,9 @@ function commerce_customer_profile_set_properties($profile, $name, $value) {
+  $form_state['order'] = commerce_order_load($form_state['order']->order_number);

This is wrong as it expects order_id not order_number
$order = commerce_order_load($form_state['order']->order_id);