Fix entity property info of product / customer profile / line item reference fields

Ahh, was this a recent change or something we've had wrong all along? I'm guessing we'll have the same bug in Customer / Line Item for the customer profile reference and line item reference fields.

Ok, thanks for the extra info. I'm a little confused then why we're not using the query callback or setter / getter callback for customer profile reference fields:

/**
 * Callback to alter the property info of the reference field.
 *
 * @see commerce_customer_field_info().
 */
function commerce_customer_profile_property_info_callback(&$info, $entity_type, $field, $instance, $field_type) {
  $property = &$info[$entity_type]['bundles'][$instance['bundle']]['properties'][$field['field_name']];
  $property['options list'] = 'entity_metadata_field_options_list';
  unset($property['query callback']);
}

The same code is used for the line item reference field.

(On a side note, that function is not helpfully named; think I'll update it to make it explicit it's for the reference field.)

'query callback' is supposed to be deprecated #1345882: Undeprecate 'query callback' when used with a 'computed' property.
But I'm wondering why are we unsetting it in each field property callback.

See also #1306106: Can't load nodes via a product reference in a rule

Marking this one #1306106: Can't load nodes via a product reference in a rule as duplicated, as this change would fix the issue there.

Hi

I had a problem with 7.x-1.1 where I couldn't reference product replacement tokens via my display node type.

I was using the tokens for display of custom breadcrumbs and auto urls.

After chatting with pcambra, I was advised to apply this patch - I did so, and now I have replacement tokens.

Thanks all.

Hi, Could this patch also solve the problem that term references to products are not shown as real terms, and term references to product-displays are shown as real terms?
greetings, Martijn

Let's see how this patch goes, then. It removes everything from our reference field property info definition except the options list callback. If that isn't necessary, let's remove it, too. Any tips on that, fago?

Actually there's already an issue to remove the line item reference query callback #1358760: Rules "Fetch entity by property" action with line item reference field, marking that one as duplicate.

Wonderful, thanks so much guys! Glad to get this fixed - love seeing you in the queue, fago. : )

Commit: http://drupalcode.org/project/commerce.git/commitdiff/7f45495