Hi, from Ryan's talk at Drupalcon, I got the impression that Commerce integrated with Features - specifically Product Types.

I went to Structure -> Features -> Create Feature, and in the "Edit Components" dropdown didn't see my custom product types.

Am I missing something? Is this planned for 1.0? Or should I custom code my product type module.

Thanks in advance,

Mike

quickstart@qs09:~/websites/test.tst$ drush pm-list --status=enabled --no-core
 Package           Name                                               Type    Version       
 Chaos tool suite  Chaos tools (ctools)                               Module  7.x-1.x-dev   
 Commerce          Cart (commerce_cart)                               Module  7.x-1.x-dev   
 Commerce          Checkout (commerce_checkout)                       Module  7.x-1.x-dev   
 Commerce          Commerce (commerce)                                Module  7.x-1.x-dev   
 Commerce          Commerce UI (commerce_ui)                          Module  7.x-1.x-dev   
 Commerce          Customer (commerce_customer)                       Module  7.x-1.x-dev   
 Commerce          Customer UI (commerce_customer_ui)                 Module  7.x-1.x-dev   
 Commerce          Line Item (commerce_line_item)                     Module  7.x-1.x-dev   
 Commerce          Line Item UI (commerce_line_item_ui)               Module  7.x-1.x-dev   
 Commerce          Order (commerce_order)                             Module  7.x-1.x-dev   
 Commerce          Order UI (commerce_order_ui)                       Module  7.x-1.x-dev   
 Commerce          Payment (commerce_payment)                         Module  7.x-1.x-dev   
 Commerce          Payment Method Example (commerce_payment_example)  Module  7.x-1.x-dev   
 Commerce          Payment UI (commerce_payment_ui)                   Module  7.x-1.x-dev   
 Commerce          Price (commerce_price)                             Module  7.x-1.x-dev   
 Commerce          Product (commerce_product)                         Module  7.x-1.x-dev   
 Commerce          Product Pricing (commerce_product_pricing)         Module  7.x-1.x-dev   
 Commerce          Product Pricing UI (commerce_product_pricing_ui)   Module  7.x-1.x-dev   
 Commerce          Product Reference (commerce_product_reference)     Module  7.x-1.x-dev   
 Commerce          Product UI (commerce_product_ui)                   Module  7.x-1.x-dev   
 Commerce          Tax (commerce_tax)                                 Module  7.x-1.x-dev   
 Commerce          Tax UI (commerce_tax_ui)                           Module  7.x-1.x-dev   
 Features          Features (features)                                Module  7.x-1.x-dev   
 Fields            Address Field (addressfield)                       Module  7.x-1.x-dev   
 Other             Entity API (entity)                                Module  7.x-1.x-dev   
 Other             Entity tokens (entity_token)                       Module  7.x-1.x-dev   
 Rules             Rules (rules)                                      Module  7.x-2.0-beta1 
 Rules             Rules UI (rules_admin)                             Module  7.x-2.0-beta1 
 Views             Views (views)                                      Module  7.x-3.x-dev

Comments

rszrama’s picture

rszrama commented
Component: Developer experience » Contributed modules

Hey Mike, sorry if I gave off the wrong impression, but while work has been done to provide Features-specific integration for product types, it's lagging behind and needs to be redone. I'm pushing a few people to dive into a "Commerce Features" module that we can develop outside of core so it can adapt to changes in Features faster than core might be able to. What we have done at the core level is make sure all our entity types and custom data structures are defined via hooks and not simply stored in / retrieved from the database.

If anyone is already working on an updated Features integration, can you chime in?

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented

I'm working on this, I hope to have something within this week :)

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Component: Contributed modules » Product
Category: bug » feature
Status: Active » Needs review

Reusing this issue to implement the changes needed for the features integration.

Basically are minor changes, one is checking if the record already exists in the database when you edit a feature provided product type that was created using commerce_product_ui.
The other is checking if the product type already has a module defined, if so, we keep it, if not we put the current module.

Repo: git.drupal.org:sandbox/pcambra/1081200.git
Branch: 1108166
Diff: http://drupalcode.org/sandbox/pcambra/1081200.git/commitdiff/86ace045e5a...

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented

http://drupal.org/project/commerce_features

rszrama’s picture

rszrama commented
Status: Needs review » Fixed

I've committed these manually. I think I know what's happening with your branches... it looks like you're not always making a new branch from your 7.x-1.x branch. The one you linked in comment 3 includes commits from your work on adjustable tax rate weights, so I can only guess that perhaps you branched from there.

MichaelCole’s picture

MichaelCole commented

Awesome guys, thanks!

I'll try it out and watch the issue queue.

I'm really impressed with this project, thanks again,

Mike

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.