Checkout review pane shows pane review information unconditionally [#1061308]

The checkout review pane shows an outline of all the panes from the first checkout page even if the "Include this pane on the Review checkout pane." option is unchecked, we'll need to review commerce_checkout_review_pane_checkout_form function.

Comment	File	Size	Author
#3	combined_calls_to_commerce_checkout_pane_callback_in_commerce_checkout_review_pane_checkout_form-1061308-3.patch	2.04 KB	guypaddock

Comments

Comment #1

rszrama commented 23 February 2011 at 06:13

Issue tags:

+low-hanging fruit

Tagging.

Comment #2

pcambra

he/him

Spanish

commented 28 February 2011 at 15:41

Issue tags:

+dcparisprintmarch

Tagging

Comment #3

guypaddock commented 10 April 2011 at 03:02

Status:

Active

» Needs review

Status	File	Size
new	combined_calls_to_commerce_checkout_pane_callback_in_commerce_checkout_review_pane_checkout_form-1061308-3.patch	2.04 KB

This did indeed turn out to be low-hanging fruit, and was indeed in commerce_checkout_review_pane_checkout_form(); the function was correctly filtering the panes, but then throwing away the applicable panes and just doing a query for all the panes that came before the review step.

The attached patch should fix this issue.