I received the "node author" notification e-mail for a comment on a content type that has not enabled notifications at all. This seems to be a bug, right? Sorry if this has already been taken care about.

CommentFileSizeAuthor
#2 511644_comment_notify_node_alter_for_certain_types.patch1.09 KBgreggles

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

The node notifications don't respect that setting...that setting only applies to where end users will be able to subscribe to comments via a comment thread.

So...two possibilities:
1. Make node notifications respect that setting
2. Change the UI for the setting to make it clear that it only affects comment subscription

I think the latter is better.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Version: 6.x-1.2 » 7.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new 511644_comment_notify_node_alter_for_certain_types.patch1.09 KB

Actually, maybe this does make sense...attached small patch should fix it and is not terribly complex. Could you test it out?

roball’s picture

roball commented

Dear Greg,

I appreciate your work on this - however I am sorry to say that I am not able to test your patch. Neither I am using this module anymore (now using Notifications instead) nor I have a 7.x Drupal at hands.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Version: 7.x-1.x-dev » 6.x-1.x-dev

It works for 6.x, actually-not sure how that changed.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Fixed

It appears I committed this in http://drupal.org/cvs?commit=277496

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.