Problem/Motivation

This issue aims to bring the module up to date by adopting modern PHP capabilities and aligning with current Drupal core APIs.

There is a list of issues to implement:
#3021537: 8.x - Allow users to subscribe without posting a comment
#3616716: Remove jquery dependency in JS behaviors
#3616721: Per-bundle settings
#3616719: Move comment_notify.inc functions to separate service
#3616715: Use OOP hook implementations

And after implementing these issues, we need to cover the module with tests

Comments

igor mashevskyi created an issue. See original summary.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Issue summary: View changes

Thanks for starting this.

Turning those links into issue links so we can see the titles and status.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Do you think that when these things are fixed it should become 2.0.0 or maybe it would be OK as 8.x-1.7?

I could also see doing most of these in 8.x and then making a new 2.x branch where the work on 3021573 and 3616721 could land as those feel like a bit of a new level of changes.

gnuget’s picture

gnuget
Primary language Spanish
commented

There only one reason why I believe this should be moved to version 2 and it is because in #3616715: Use OOP hook implementations was used a feature that was added until Drupal 10.1 So this new release will drop Drupal 9.x and Drupal 10.0 support

This could break some Drupal9 sites. But I'm not so sure if this is enough argument to release this as a new major version.

What do you think?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

That's a great point.

I'm not sure what we want our BC policy to be. If we wanted 2.x to be the one that breaks compatability with 10.0 and below then we will need to branch the 2.0.x, and revert that commit from 8.x-1.x in case we want to do a new release from that.

Or we could just put in the release notes of the next 8.x-1.x release that it no longer supports 10.0 (which is EOL pretty soon anyway).

Do you have a proposal for how to handle this? Or gnuget?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Sorry, just realized comment #4 was you, gnuget :)

@igor what do you think about when to branch?