Yep.

Requires a new database table and pulling the data out of $user->data.

See signup's signup_update_5204 for a model of how to batch something during an udpate.

CommentFileSizeAuthor
#4 348000_5x_comment_notify_user_settings_4.patch10.19 KBgreggles
#4 348000_6x_comment_notify_user_settings_4.patch6.45 KBgreggles
#3 348000_5x_comment_notify_user_settings_3.patch10.14 KBgreggles
#2 348000_5x_comment_notify_user_settings_2.patch0 bytesgreggles
#1 348000_5x_comment_notify_user_settings_1.patch9.25 KBaclight

Comments

aclight’s picture

aclight commented
Status: Active » Needs review
StatusFileSize
new 348000_5x_comment_notify_user_settings_1.patch9.25 KB

Here's a patch for the D5 version of comment_notify. I don't have many users in this test site that have any comment_notify data for them in {users}.data, but for the few users I do have this update worked. I have only tested on mysql, not pgsql. I named the update function here 5201, based on my guess that #317640: Remove "notify" column from comments table will probably be committed first, but feel free to rename if necessary.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
StatusFileSize
new 348000_5x_comment_notify_user_settings_2.patch0 bytes

Updated version for 5.x

1) Fixes a parse error in the install
2) Fixes a notice when loading users

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
StatusFileSize
new 348000_5x_comment_notify_user_settings_3.patch10.14 KB

Let's try that again.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
StatusFileSize
new 348000_6x_comment_notify_user_settings_4.patch6.45 KB
new 348000_5x_comment_notify_user_settings_4.patch10.19 KB

Here's a 6.x version and a new 5.x version that is more likely to work than the last few ;)

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Fixed

I tested the 6.x on a site with a few different values in the user->data column and everything worked as expected.

I've committed the 5.x version of the patch as well, though it got no additional testing beyond my first round...here's to beta users as testers ;)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.