Closed (fixed)
Project:
Comment driven
Version:
6.x-1.0-unstable5
Component:
Theming
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
12 Mar 2010 at 04:31 UTC
Updated:
10 Dec 2010 at 21:59 UTC
Jump to comment: Most recent file
Comments
Comment #1
arhak commentedcommitted to HEAD
navigate to admin/settings/comment_driven and select "Open Atrium" under "Theme support" fieldset
Comment #2
obrienmd commentedarhak has indicated that another detail is required to make this work - I will test the new fix as soon as it is ready.
Comment #3
arhak commentedwhat theme are you using?
I'm not familiar with Open Atrium
at the testing site I'm seeing CSS files from three different themes at once:
- tao
- ginkgo
- rubik
Comment #4
arhak commented@#3 forget about it
I already downloaded Open Atrium (I didn't wan't to have to install another testing site, since they are becoming unmanageable)
Comment #5
arhak commentedafter applying this patch navigate to admin/settings/comment_driven and re-select Open Atrium support
Note that it will be unchecked due to a changed variable name
Comment #6
arhak commented#5 missed a CSS selector
Comment #7
arhak commentedcommitted to HEAD
Comment #8
arhak commentedyou'll need to clear your browser's cache
also, I'm seeing an empty div for buttons, and having no buttons makes it appear anyway
I'm not sure, but it seems an Open Atrium issue (or feature)
if it is desirable, it can be removed as well using the narrower #driven_node_container CSS selector
Comment #9
obrienmd commentedConfirming this works great with b5 of Open Atrium.
Comment #10
a_c_m commentedJust incase anyone else has this problem - Insure you turn OFF comment upload (in the content type) otherwise it wont show up.
Comment #11
arhak commented@#10 well, it seems that comment_upload will end being unsupported
the proposed alternative is not committed yet (because it isn't finished, of course)
when it does it will be announced at #739690: Compatibility with comment_upload
Comment #13
arhak commentedmarked #834714: Collapsible fieldset not working with theme Tao (and its sub-themes) as a duplicate of this
Comment #14
arhak commentedBTW the empty div mentioned at #8 is due to #759956: Empty column? (Open Atrium themes)
Comment #15
Grayside commentedWhy have an Open Atrium support option? That seems like needless clutter.
module_exists('atrium')orvariable_get('install_profile', 'default') == 'openatrium'should be a sufficient change.Comment #16
arhak commentedI don't think so,
that option does not refer to "Open Atrium support" as a support for the whole platform (profile install, module or whatsoever)
it is just addressing themes, in this particular case, it is about "Open Atrium's themes" OR ANY other theme derived from Tao (i.e. sub-themes)
therefore we don't check for OA, and we have no way to know if sub-theme "is derived from Tao"
that's why there is a manual configuration
Comment #17
Grayside commentedOkay, I can see that. Automation is still possible but not trivial.
You could put something in place for folks that don't make the (distinct) effort to swap out ginkgo, but that's definitely on a bonus points level.
Comment #18
arhak commentednear impossible with context and spaces
some weird condition might trigger a theme switch,
and we won't be wise enough,
so let the user manually set the flag,
and if by some weird reason it should perform with two themes Tao and non-Tao, then trigger that variable change as well