another drupal module developer not caring for php errors... *sigh*

CommentFileSizeAuthor
colophon-fix-php-errors.patch1.47 KBeMPee584

Comments

Max_Headroom’s picture

Max_Headroom commented

*sigh*
Another High-all-mighty leaving snotty remarks instead of just giving help.

Thanks, I guess. I'll test and commit where needed.

eMPee584’s picture

eMPee584 commented

well a) i did just give help and b) this is like the 15th module i'm sending stupid level bugfixes in because *some* developers do not seem to f***g care. Cleaning 50000 php error watchdog entries is not fun exactly, too!

Max_Headroom’s picture

Max_Headroom commented
Status: Needs review » Fixed

Well, you are not helping by pissing people of with comments like that and presuming that we don't "f***g" care.
What setting do you have on to get all your PHP watchdog errors? Because this module does not generate PHP errors on my test site.

Changes are being committed today.

eMPee584’s picture

eMPee584 commented

well there are some info files which don't contain the package line, so that throws an error. And if you want to use a global var without telling php, that throws an error too. And well if you take that piece of cynicism so damn serious that you get pissed of, well what do you think exactly my feelings were regarding the fact that i had to fix simple php errors and a massive amount of coder warnings (fsckin coding style guide, anyone?!) in almost every single module i tried? that's not exactly entertaining and on that day i filed like 10 patches and yours was pretty much at the end, so 'soorrry' if i stepped on your toe but we're dealing with bigger issues here.

eMPee584’s picture

eMPee584 commented
Status: Fixed » Active

Use of undefined constant user_access - assumed 'user_access' in /var/www/drupal-hfopi/sites/all/modules/colophon/colophon.module on line 46.

well eh.. yeah. what's there more to say ;)

Max_Headroom’s picture

Max_Headroom commented
Status: Active » Fixed

Thank you very very much eMPee584, for finding and fixing problems in my code.

eMPee584’s picture

eMPee584 commented

uhh does that smell a weee bit sarcastic :=P

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.