Hi,
I am using Coder trying to convert a D6 module to D7 and I get what I think is false critical warning in 3 places:
#
Line 129: Context has been added to t as the third parameter, locale has to be an element in the array. Example: array("context" => "frontpage", "locale" => "de"). (Drupal Docs)
'#description' => t('The default SMTP port is 25, if that is being blocked try 80. Gmail uses 465. See !url for more information on configuring for use with Gmail.', array('!url' => l(t('this page'), 'http://gmail.google.com/support/bin/answer.py?answer=13287'))),
#
severity: critical
#
Line 144: Context has been added to t as the third parameter, locale has to be an element in the array. Example: array("context" => "frontpage", "locale" => "de"). (Drupal Docs)
$encryption_description = t('Your PHP installation does not have SSL enabled. See the !url page on php.net for more information. Gmail requires SSL.', array('!url' => l(t('OpenSSL Functions'), 'http://php.net/openssl')));
#
severity: critical
Line 198: Context has been added to t as the third parameter, locale has to be an element in the array. Example: array("context" => "frontpage", "locale" => "de"). (Drupal Docs)
drupal_set_message(t('A test e-mail has been sent to @email. You may want to !check for any error messages.', array('@email' => $test_address, '!check' => l(t('check the logs'), 'admin/reports/dblog'))));
There is nothing context related in any of these calls to t(), afaics.
This is in the smtp module btw, it doesn't seem to be anything D7 related going on there and no response after 24h so I decided to do something about it as I need this module to work in D7, but I think these warnings are false anyway. Also not that Line # doesn't match exactly with original smtp.module as I have already done some fixes.
/y
Comments
Comment #1
klausiCoder 7.x-1.x is frozen now and will not receive any updates. Coder 8.x-2.x can be used to check code for any Drupal version, Coder 8.x-2.x also supports the phpcbf command to automatically fix conding standard errors. Please check if this issue is still relevant and reopen against that version if necessary.