Problem/Motivation

Drupal core is developing its own phpcs.xml.dist file at https://git.drupalcode.org/project/drupal/-/blob/11.x/core/phpcs.xml.dis...

Some sniffs have been adopted there that are missing in Coder.

Proposed resolution

  1. Go through core's phpcs.xml.dist file, compare it with ruleset.xml for the Drupal standard in Coder
  2. Add any missing sniffs to Coder
  3. Change core's phpcs.xml.dist file to depend on Coder, only having exceptions there that core does not support yet. Planned to be done in #3135935: Keep all sniffs in phpcs.xml.dist in sync with the locked version of Coder

Remaining tasks

Fix Coder, fix phpcs.xml.dist in core in #3135935: Keep all sniffs in phpcs.xml.dist in sync with the locked version of Coder.

Comments

klausi created an issue. See original summary.

  • klausi authored fcbab3b9 on 8.3.x 
    feat(EmptyPHPStatement): Add sniff for empty PHP statements, same as...
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

Missing EmptyPHPStatement found, added in https://github.com/pfrenssen/coder/pull/250

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

Adapted the PropertyDeclaration sniff and directly use it from PSR-2 https://github.com/pfrenssen/coder/pull/251 (sorry did not put the correct issue number in the git log).

  • klausi committed 59f52b89 on 8.3.x 
    feat(BackedEnumTypeSpacing): Add SlevomatCodingStandard.Classes....
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue summary: View changes
Status: Active » Fixed

Core issue already exists: #3135935: Keep all sniffs in phpcs.xml.dist in sync with the locked version of Coder.

Otherwise I'm done here, we are in sync again.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.