Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
Follow up #3117662: Several comments have sentences with extra periods at the end
Proposed resolution
https://github.com/pfrenssen/coder/pull/101
Comments
Comment #2
jungleComment #3
iyyappan.govindComment #4
iyyappan.govindHow can I test this?
Comment #5
klausiLeft some comments on the PR why I think we need to do this on existing comment sniffs instead.
Comment #6
iyyappan.govindComment #7
longwaveDo we need to implement this explicitly in Coder?
Can we use SlevomatCodingStandard.Commenting.ForbiddenComments instead?
Comment #8
quietone commentedI've implement the suggested in #7 in core. #3486996: Fix extra periods at the end of comment lines
Comment #9
klausiAs this coding standard should apply to all Drupal code we should do the same Slevomat sniff with config in Coder's ruleset.xml file.
Core is getting out of sync with Coder rules again ... please always make pull requests against Coder as well when you change core's phpcs.xml.dist file, so that we have the same standards everywhere.
Comment #10
klausiMerged https://github.com/pfrenssen/coder/pull/270 . Used the wrong issue number in the commit to #3486996: Fix extra periods at the end of comment lines, but should not matter.
I tweaked the regex to allow 3 dots at the end and only target 2 dots.