Themes do not support namespaced dependencies, see #474684: Allow themes to declare dependencies on modules
You are about to DROP all tables in your 'd8' database. Do you want to continue? (y/n): y
Starting Drupal installation. This takes a while. Consider using the [ok]
--notify global option.
Drupal\Core\Installer\Exception\InstallerException: Required modules: [error]
Required modules not found.
The following modules are required but were not found. Move them into
the appropriate modules subdirectory, such as <em>/modules</em>.
Missing modules: <div class="item-list--comma-list item-list"><ul
class="item-list__comma-list"><li><span
class="admin-missing">Drupal:action</span></li><li><span
class="admin-missing">Drupal:automated_cron</span></li><li><span
class="admin-missing">Drupal:block</span></li><li><span
class="admin-missing">Drupal:block_content</span></li><li><span
class="admin-missing">Drupal:breakpoint</span></li><li><span
class="admin-missing">Drupal:ckeditor</span></li><li><span
And so on
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | interdiff_8-12.txt | 1.01 KB | kdebisschop |
| #12 | 2857856-12.patch | 945 bytes | kdebisschop |
| #8 | 2857856-8.patch | 1.01 KB | andypost |
Comments
Comment #2
andypostThis is because https://api.drupal.org/api/drupal/core%21includes%21install.inc/function... does not remove prefixes
$missing_modules = array_diff($info['dependencies'], $present_modules);Comment #3
andypostLooks it needs separate issue for 8.x core
Comment #4
andypostComment #5
andypostAdded test https://github.com/klausi/coder/pull/25
Comment #6
andypostComment #7
andypostComment #8
andypostPatch without tests
Comment #9
andypostThe related shows that themes does not support dependencies at all
Comment #10
tobby commentedI've been using the patch in #8 with some success for the namespaced dependency issues in install profiles. Though, I'm submitting this attached patch (that I've been using locally) to just remove the sniffer altogether, since it also finds false positives in modules generated from Features (which does not use the namespaced dependencies yet, either). I know that won't be ideal for some, and probably not for the long-term support of this issue, but it's helpful for now if you have a project with a custom install profile and lots of Features modules, until Drupal 8.4 and Features both support the namespaces.
Comment #11
andypost#10 is not a fix
but actually that blocked on #2855026: Installation profiles do not support project:module format for dependencies
Comment #12
kdebisschop commentedSince https://www.drupal.org/project/drupal/issues/2855026 has merged to core, #8 should be updated to scan profiles (but still ignore themes).
Comment #13
klausiCan you add a comment that we need this because of theme info files not supporting namespaces?
Can you also provide a test case so that we can be sure this works?
Probably best to create a pull request against https://github.com/pfrenssen/coder , then we can see test results on Travis CI.
Comment #15
klausiCommitted a different approach to fix this to make an exception for theme info files.
Comment #16
klausi