Coder has some javascript support, but it has not been tested well and produces false positives in certain cases.

There is ESLint now that can check and fix javascript files, so I think we should remove javascript support completely from Coder and point people to ESLint:
http://eslint.org/
https://www.drupal.org/node/1955232

Comments

klausi created an issue. See original summary.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

As a first step I wanted to set default file extensions where JS files are removed, but that is breaking tests right now: https://github.com/klausi/coder/pull/3

Also filed a PR upstream at PHPCS: https://github.com/squizlabs/PHP_CodeSniffer/pull/1032

anoopjohn’s picture

anoopjohn commented

Will eslint take care of javascript standards in Drupal 7 as well?

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

Sure, I assume they are the same as in drupal 8.

  • klausi committed 5f5447e on 8.x-2.x 
    Issue #2746449: Remove JavaScript support and point users to eslint
dawehner’s picture

dawehner
Primary language German
commented

Nice idea!

Just in general, there seems to be also an effort to standardize things even more in the javascript world: http://standardjs.com/index.html

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Active » Fixed

Removed the *.js extension from the doc page at https://www.drupal.org/node/1587138 , I think we are done here.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.