Here is the patch that adds a review to check code compliance with HipHopPHP.

CommentFileSizeAuthor
coder_hiphopphp.inc_.patch4.81 KBbenoit.borrel

Comments

benoit.borrel’s picture

benoit.borrel commented
Status: Active » Needs review
pillarsdotnet’s picture

pillarsdotnet commented

Maybe you should make a Drupal distro that is optimized/hacked to run under HipHop. I for one would be very interested.

benoit.borrel’s picture

benoit.borrel commented

An HipHopPHP compatible distro is already available as a Pressflow branch and instructions to set up the stack are documented in FourKitchens' wiki.

My idea was to help module developers writing code that is compliant with HipHopPHP, thus the proposed CodeR review.

pillarsdotnet’s picture

pillarsdotnet commented

Thanks for the link. Couldn't actually compile the code, as it requires x86_64 and I only have x86_32. Looking forward to a more general solution.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs review » Needs work

- Most UI texts have not been wrapped in t() calls, so they cannot be translated.
- Some UI texts contain broken up sentences (too many periods and commas).
- Some sentences don't start with a capital letter or end with a period.
- The patch doesn't follow the coding standards, notably those regarding code comments.
- Don't use abbreviated variable names. Use $key and $value rather than $k and $v, or better, use $function_name for $v instead.
- If you don't need an associative array's keys when looping through them, don't use them in the foreach's definition.

benoit.borrel’s picture

benoit.borrel commented
Status: Needs work » Needs review

The page which was the reference and the reason of this code compliance review has gone on May 6, 2011. May it rest in peace within www.archive.org.

Anyway, I guess one should better use the HipHopPHP GitHub issues queue instead.

I guess you could set this issue as "closed (won't fix)".

pillarsdotnet’s picture

pillarsdotnet commented
Relevant link and sandbox project:
http://php.webtutor.pl/en/2011/05/31/drupal-hh7-project-hiphop-for-php-and-drupal-7-2-compatibility-patch/
http://drupal.org/sandbox/sun/1181434
sun’s picture

sun
Primary language German
Location Karlsruhe
commented

wow, nice idea, subscribing

douggreen’s picture

douggreen commented
Version: 6.x-2.0-beta1 » 7.x-2.x-dev

Is this still valid? Has anyone made a contrib module with these rules?

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue summary: View changes
Status: Needs review » Closed (won't fix)

Coder 7.x is frozen now and will not receive updates. Coder 8.x-2.x can be used to check code for any Drupal version, Coder 8.x-2.x also supports the phpcbf command to automatically fix conding standard errors. Please check if this issue is still relevant and reopen against that version if necessary.