CommentFileSizeAuthor
#7 3264004-7.patch5.32 KBneslee canil pinto
#3 3264004-3.patch5.29 KBneslee canil pinto
#2 3264004-2.patch5.43 KBneslee canil pinto

Comments

Neslee Canil Pinto created an issue. See original summary.

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 3264004-2.patch5.43 KB
neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
StatusFileSize
new 3264004-3.patch5.29 KB

Updated patch

tmaiochi’s picture

tmaiochi commented
Assigned: Unassigned » tmaiochi

I'll review this!

tmaiochi’s picture

tmaiochi commented
Assigned: tmaiochi » Unassigned
Status: Needs review » Reviewed & tested by the community

Steps performed:
(1) Installed module
(2) Reproduced the issue.
(3) Applied patch.
(4) Code review on changes.
(5) Tested again with patch, issue resolved.
The patch fixed deprecated code and made compatible with D9.

jurriaanroelofs’s picture

jurriaanroelofs commented

@tmaiochi did you make any edits to the patch before trying it successfully? What branch did you test against?
It doesn't seem like the patch is working against 8.x-1.x.

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3264004-7.patch5.32 KB

Updated new patch

jurriaanroelofs’s picture

jurriaanroelofs commented
Status: Needs review » Fixed

Thx Neslee

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.