Problem/Motivation

If the muted option is selected, we no longer show the dimensions in the field formatter settings summary.

Proposed resolution

Show dimensions in the field formatter summary if the muted option is selected.

CommentFileSizeAuthor
#4 if_the_muted_option_is_selected_we_no_longer_show_the_dimensions_in_the_field_formatter_settings_summary-3224010-3.patch1.19 KBpjbaert
#2 Screenshot 494.png16.28 KBpjbaert
#2 if_the_muted_option_is_selected_we_no_longer_show_the_dimensions_in_the_field_formatter_settings_summary-3224010-2.patch1.49 KBpjbaert

Comments

pjbaert created an issue. See original summary.

pjbaert’s picture

pjbaert
Primary language Dutch
commented
Assigned: pjbaert » Unassigned
Status: Active » Needs review
StatusFileSize
new if_the_muted_option_is_selected_we_no_longer_show_the_dimensions_in_the_field_formatter_settings_summary-3224010-2.patch1.49 KB
new Screenshot 494.png16.28 KB

This patch resolves the bug which was hiding the dimensions when the mute option was selected in the field formatter summary.
summary

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Needs review » Needs work 
+++ b/src/Plugin/Field/FieldFormatter/CloudflareVideoFormatter.php	(date 1626452090996)
@@ -89,9 +89,10 @@
-    $dimensions = $this->getSetting('muted') ? $this->t('Muted') : $this->t('@widthx@height', ['@width' => $this->getSetting('width'), '@height' => $this->getSetting('height')]);
+    $dimensions = $this->t('@widthx@height', ['@width' => $this->getSetting('width') ? $this->getSetting('width') : '100%', '@height' => $this->getSetting('height') ? $this->getSetting('height') : '100%']);

This change of the 100% does not belong in this patch.

pjbaert’s picture

pjbaert
Primary language Dutch
commented
StatusFileSize
new if_the_muted_option_is_selected_we_no_longer_show_the_dimensions_in_the_field_formatter_settings_summary-3224010-3.patch1.19 KB

I updated the patch.
The width & height issue will be followed-up in another ticket.
Please review.

pjbaert’s picture

pjbaert
Primary language Dutch
commented
Status: Needs work » Needs review
tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Thx, this is working correct now.

  • pjbaert committed 78e492f on 8.x-2.x 
    Issue #3224010 by pjbaert, tim-diels: If the muted option is selected,...
pjbaert’s picture

pjbaert
Primary language Dutch
commented
Status: Reviewed & tested by the community » Fixed

Thank you for reviewing. This was pushed to 8.x-2.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.