There is a comment for a variable that is missing a *

  /*
   * Http timeout time.
   */
  protected $timeout;

Should be 

  /**
   * Http timeout time.
   */
  protected $timeout;
CommentFileSizeAuthor
#6 3223979-use_correct_formatting_in_comment_blocks-6.patch2.08 KBtim-diels
#4 3223979-use_correct_formatting_in_comment_blocks-4.patch2.03 KBpjbaert
#2 3223979-use_correct_formatting_in_comment_blocks-2.patch442 bytestim-diels

Comments

tim-diels created an issue. See original summary.

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Active » Needs review
StatusFileSize
new 3223979-use_correct_formatting_in_comment_blocks-2.patch442 bytes
pjbaert’s picture

pjbaert
Primary language Dutch
commented
Status: Needs review » Needs work

I noticed there are more comment blocks with the wrong formatting.
Let's update them all in this ticket.

pjbaert’s picture

pjbaert
Primary language Dutch
commented
Status: Needs work » Needs review
StatusFileSize
new 3223979-use_correct_formatting_in_comment_blocks-4.patch2.03 KB

Added some more *'s to fix all comment blocks.
I believe I caught them all. Please review.

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Needs review » Needs work

Think you forgot to include my patch?

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new 3223979-use_correct_formatting_in_comment_blocks-6.patch2.08 KB

This patch is the combination of both.

  • pjbaert committed 0778196 on 8.x-2.x authored by tim-diels 
    Issue #3223979 by tim-diels, pjbaert: Use correct formatting in comment...
pjbaert’s picture

pjbaert
Primary language Dutch
commented
Status: Needs review » Fixed

Thanks for your rework!
This was pushed to the 8.x-2.x branch

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.