Configure Option is missing on Module Page. Please see the screenshot.

CommentFileSizeAuthor
#7 configure-option-is-missing-on-extend-page-3159839-7.patch335 bytespjbaert
#6 configure-option-is-missing-on-extend-page-3159839-5.patch400 bytestim-diels
#2 Screen Shot 2020-07-17 at 5.39.24 PM.png487.25 KBramya balasubramanian
#2 configure-option-is-missing-on-extend-page-3159839-2.patch347 bytesramya balasubramanian
Screen Shot 2020-07-17 at 5.36.39 PM.png478.92 KBramya balasubramanian

Comments

Ramya Balasubramanian created an issue. See original summary.

ramya balasubramanian’s picture

ramya balasubramanian commented
StatusFileSize
new configure-option-is-missing-on-extend-page-3159839-2.patch347 bytes
new Screen Shot 2020-07-17 at 5.39.24 PM.png487.25 KB

Hi,

I have updated the patch and screenshot. Please have a look.

pjbaert’s picture

pjbaert
Primary language Dutch
commented
Status: Active » Reviewed & tested by the community

This patch adds the path to the configuration page correctly

pjbaert’s picture

pjbaert
Primary language Dutch
commented
Version: 8.x-1.0 » 8.x-2.x-dev
Status: Reviewed & tested by the community » Needs review

Could we test this against the 2.x-dev branch?

pjbaert’s picture

pjbaert
Primary language Dutch
commented
Status: Needs review » Needs work

Testing failed. This patch needs to be reworked

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new configure-option-is-missing-on-extend-page-3159839-5.patch400 bytes

Re-rolled for 2.x

pjbaert’s picture

pjbaert
Primary language Dutch
commented
StatusFileSize
new configure-option-is-missing-on-extend-page-3159839-7.patch335 bytes

Thanks for the reroll!

Small nitpick:

+++ b/cloudflare_stream.info.yml
@@ -3,3 +3,4 @@ description: Provides field widget for streaming videos using Cloudflare Stream
\ No newline at end of file

This is fixed on the attached patch.

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Sorry, thanks for the good eyes on the patch!

pjbaert’s picture

pjbaert
Primary language Dutch
commented
Status: Reviewed & tested by the community » Fixed

This was pushed to the 8.x-2.x branch. Thank you all for your work!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.