Problem/Motivation
- When updating any of the
SPA settingson the /admin/config/services/cloud/settings page, the user submitted settings are ignored if theUse React single page application (SPA)is checked. - The following code in the
CloudAdminSettings::submitForm()prevents the user from updating those settings.
if ($use_spa && !$use_spa_by_config) { $this->enableSpaApp( $form_state->getValue('cloud_spa_key_directory'), $form_state->getValue('cloud_spa_callback_url') ); } elseif (!$use_spa) { $this->disableSpaApp(); }
Issue fork cloud-3363995
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
baldwinlouie commented@yas please review this patch. This fixes the configuration form error when updating SPA values.
Comment #4
yas@baldwinlouie
Thank you for the fix. I'll merge the patch to
5.xand6.x, and close this issue as Fixed.Comment #7
yas