Problem/Motivation

  • Add an option to turn on/off SPA on the admin/config/services/cloud/settings configuration form.
CommentFileSizeAuthor
#3 Cloud___Cloud_Orchestrator.png80.19 KBbaldwinlouie
#3 Cloud___Cloud_Orchestrator.png162.34 KBbaldwinlouie

Issue fork cloud-3356454

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

baldwinlouie created an issue. See original summary.

baldwinlouie opened merge request !1743

baldwinlouie’s picture

baldwinlouie commented
Status: Active » Needs review
StatusFileSize
new Cloud___Cloud_Orchestrator.png162.34 KB
new Cloud___Cloud_Orchestrator.png80.19 KB

@yas, this patch adds support for toggling the SPA on/off. Since we don't specify drupal/simple_oauth in the Cloud module's composer.json anymore, I'm doing a check to make sure that module is available before toggling SPA on.

The reason is that if cloud_dashboard is not enabled in an installation, I will enable it and setup the simple_oauth consumer. If drupal/simple_oauth is not available, we will encounter an error. This could happen if a user downloads cloud module without using the Cloud Orchestrator distribution.

For now, you still need to manually compile the SPA before this works. I will check in a compiled SPA once we fix the issues identified for it.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +chatgpt

@baldwinlouie

Thank you for the patch. It looks good. I posted my comments. Thanks!

baldwinlouie’s picture

baldwinlouie commented
Status: Needs work » Needs review

@yas, please review the updated patch.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add option to turn on/off SPA application. » Add an option to turn on/off SPA application
Status: Needs review » Needs work

@baldwinlouie

Thank you for the update. Can you please fix the coding standard error?

https://www.drupal.org/pift-ci-job/2652496

Thanks

baldwinlouie’s picture

baldwinlouie commented
Status: Needs work » Needs review

@yas, the coding standard is fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@baldwinlouie

Thank you for the update. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed 59f2ca80 on 6.x authored by baldwinlouie 
    Issue #3356454 by baldwinlouie, yas: Add an option to turn on/off SPA...

  • yas committed c14c9e0d on 5.x authored by baldwinlouie 
    Issue #3356454 by baldwinlouie, yas: Add an option to turn on/off SPA...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Fixed » Needs work

@baldwinlouie

Sorry, I found the following coding standard violation. Can you please create a hotfix? Thanks!

FILE: ...web/modules/contrib/cloud/src/Form/Config/CloudAdminSettings.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 300 | WARNING | \Drupal calls should be avoided in classes, use
     |         | dependency injection instead
----------------------------------------------------------------------

baldwinlouie opened merge request !1751

baldwinlouie’s picture

baldwinlouie commented
Status: Needs work » Needs review

@yas please review the hotfix.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@baldwinlouie

Thank you for the hotfix. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed ca09215c on 6.x authored by baldwinlouie 
    Issue #3356454 by baldwinlouie, yas: Hotfix - Add an option to turn on/...

  • yas committed 86b7b4d3 on 5.x authored by baldwinlouie 
    Issue #3356454 by baldwinlouie, yas: Hotfix - Add an option to turn on/...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.