Problem/Motivation

  • Fix missing schemas for views.view.aws_cloud_volume and views.view.openstack_volume with the following errors:
    • views.view.aws_cloud_volume:display.default.display_options.fields.created.settings.tooltip missing schema
    • views.view.aws_cloud_volume:display.default.display_options.fields.created.settings.time_diff missing schema
    • views.view.aws_cloud_volume:display.all.display_options.fields.created.settings.tooltip missing schema
    • views.view.aws_cloud_volume:display.all.display_options.fields.created.settings.time_diff missing schema
    • views.view.openstack_volume:display.default.display_options.fields.created.settings.tooltip missing schema
    • views.view.openstack_volume:display.default.display_options.fields.created.settings.time_diff missing schema
    • views.view.openstack_volume:display.all.display_options.fields.created.settings.tooltip missing schema
    • views.view.openstack_volume:display.all.display_options.fields.created.settings.time_diff missing schema

Issue fork cloud-3355256

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yas created an issue. See original summary.

yas opened merge request !1732

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs work » Reviewed & tested by the community
Related issues: +#3355219: Drupal 10.1.x compatibility: Refactor system_time_zones() to use \Drupal\Core\Datetime\TimeZoneFormHelper::getOptionsList()

@all

Based on the test results, even there are some errors, the patch should fix the issue. I'll merge the patch into the 7.x branch in the future and close this issue.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Drupal 10.1.x compatibility: Fix missing schemas in views.view.aws_cloud_volume (tooltip and time_diff) » Drupal 10.1.x compatibility: Fix missing schemas in views.view.aws_cloud_volume and openstack_volume (tooltip and time_diff)
Issue summary: View changes

yas opened merge request !1821

yas closed merge request !1821

yas closed merge request !1732

yas opened merge request !1826

yas closed merge request !1826

yas opened merge request !2057

yas closed merge request !2057

yas opened merge request !2058

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work

@baldwinlouie

Can you review the patch?

FYI, I validated the schama by using drupal/cloud_inspector:

$ drush status
Drupal version   : 10.1.6-dev                                 
Site URI         : http://default                             
DB driver        : mysql                                      
DB hostname      : 172.17.0.1                                 
DB port          : 3306                                       
DB username      : root                                       
DB name          : dev1                                       
Database         : Connected                                  
Drupal bootstrap : Successful                                 
Default theme    : rigel                                      
Admin theme      : claro                                      
PHP binary       : /usr/local/bin/php                         
PHP config       : /usr/local/etc/php/php.ini                 
PHP OS           : Linux                                      
PHP version      : 8.2.11                                     
Drush script     : /var/www/html/vendor/drush/drush/drush     
Drush version    : 12.2.0.0                                   
Drush temp       : /tmp                                       
Drush configs    : /var/www/html/vendor/drush/drush/drush.yml 
Install profile  : standard                                   
Drupal root      : /var/www/html/web                          
Site path        : sites/default                              
Files, Public    : sites/default/files                        
Files, Private   : sites/default/files/private                
Files, Temp      : /tmp

BEFORE (Current version):

$ drush  config:inspect --only-error
 Legend for Data: 
  ✅❓  → Correct primitive type, detailed validation impossible.
  ✅✅  → Correct primitive type, passed all validation constraints.
 ----------------------------- ----------- ------------- ---------- 
  Key                           Status      Validatable   Data      
 ----------------------------- ----------- ------------- ---------- 
  bootstrap5.settings           6 errors                            
  cloud_dashboard.settings      No schema                           
  memcache_admin.settings       1 errors                            
  rigel.settings                8 errors                            
  system.theme.global           Correct     41%           1 errors  
  update.settings               Correct     14%           1 errors  
  views.view.aws_cloud_volume   4 errors                            
  views.view.openstack_volume   4 errors                            
 ----------------------------- ----------- ------------- ----------

AFTER (Applying the patch):

$ drush  config:inspect --only-error
 Legend for Data:
  ✅❓  → Correct primitive type, detailed validation impossible.
  ✅✅  → Correct primitive type, passed all validation constraints.
 -------------------------- ----------- ------------- ---------- 
  Key                        Status      Validatable   Data      
 -------------------------- ----------- ------------- ---------- 
  bootstrap5.settings        6 errors                            
  cloud_dashboard.settings   No schema                           
  memcache_admin.settings    1 errors                            
  rigel.settings             8 errors                            
  system.theme.global        Correct     41%           1 errors  
  update.settings            Correct     14%           1 errors  
 -------------------------- ----------- ------------- ----------

Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
baldwinlouie’s picture

baldwinlouie commented
Status: Needs review » Reviewed & tested by the community

@yas, Thank you for the patch. It looks good to me.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@baldwinlouie

Thank you for your review. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed f87e1bb5 on 6.x 
    Issue #3355256 by yas, baldwinlouie: Drupal 10.1.x compatibility: Fix...

  • yas committed 67fbc1a4 on 5.x 
    Issue #3355256 by yas, baldwinlouie: Drupal 10.1.x compatibility: Fix...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.