Problem/Motivation

  • After Drupal 10.1.x, Fix the following warning at k8s_timezone_allowed_values_function():
    system_time_zones() is deprecated in drupal:10.1.0 and is removed from drupal:11.0.0. This function is no longer used in Drupal core. Use \Drupal\Core\Datetime\TimeZoneFormHelper::getOptionsList(), \Drupal\Core\Datetime\TimeZoneFormHelper::getOptionsListByRegion() or \DateTimeZone::listIdentifiers() instead. See https://www.drupal.org/node/3023528
    25x in K8sCloudConfigTest::testCloudConfig from Drupal\Tests\k8s\Functional\cloud\config
    9x in K8sCloudConfigTest::testK8sMenu from Drupal\Tests\k8s\Functional\cloud\config
    4x in K8sCloudConfigTest::testCloudConfigRedirect from Drupal\Tests\k8s\Functional\cloud\config
    1x in K8sCloudConfigTest::testCloudConfigBulk from Drupal\Tests\k8s\Functional\cloud\config

Issue fork cloud-3355219

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yas created an issue. See original summary.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Refactor system_time_zones() to use \Drupal\Core\Datetime\TimeZoneFormHelper::getOptionsList() » Drupal 10 compatibility: Refactor system_time_zones() to use \Drupal\Core\Datetime\TimeZoneFormHelper::getOptionsList()
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Drupal 10 compatibility: Refactor system_time_zones() to use \Drupal\Core\Datetime\TimeZoneFormHelper::getOptionsList() » Drupal 10.1.x compatibility: Refactor system_time_zones() to use \Drupal\Core\Datetime\TimeZoneFormHelper::getOptionsList()
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Active

yas opened merge request !1731

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Active » Needs review

@sekinet

Can you please review the patch?

Thanks

sekinet’s picture

sekinet commented
Status: Needs review » Reviewed & tested by the community

@yas

Thank you for the patch. It looks good.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@sekinet

Thank you for your review. I'll merge the patch into the 7.x future branch.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@sekinet

drupal/cloud:6.0.0 has been released at and 7.x-dev branch is created, so I'll merge the patch to 7.x only, and close this issue as Fixed.

  • yas committed 14da6e96 on 7.x 
    Issue #3355219 by yas, sekinet: Drupal 10.1.x compatibility: Refactor...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.