Problem/Motivation

Following the adoption of the SimpleDataTables library, columns with mixed data (example 128 days) would use the default sorting type of the library ("string") hence returning wrongfully sorted data.

CommentFileSizeAuthor
#4 3246286-4.patch858 bytesxld

Issue fork cloud-3246286

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

XLD created an issue. See original summary.

xld’s picture

xld commented
Issue summary: View changes

XLD opened merge request !480

xld’s picture

xld commented
Status: Needs work » Needs review
StatusFileSize
new 3246286-4.patch858 bytes
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@XLD

Thank you for the refactoring. I tested the patch and it works fine. I'll merge the patch to 4.x and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Reviewed & tested by the community

yas closed merge request !480

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

  • yas committed 60a0fa9 on 3.x authored by XLD 
    Issue #3246286 by XLD, yas: Table sorting for columns with mixed data...

  • yas committed 6da058d on 4.x authored by XLD 
    Issue #3246286 by XLD, yas: Table sorting for columns with mixed data...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.