Problem/Motivation

Add test cases for OpenStack Admin Setting forms:

  • Drupal\Tests\OpenStack\Functional\Config\OpenStackAdminSettings::testOpenStackAdminSettings()

Specification:

  • Implement Drupal\Tests\OpenStack\Traits\OpenStackTestFormDataTrait\createOpenStackSettingsTestFormData() to return an array including the random input data for /admin/config/services/openstack/settings
  • Access (HTTP Get) /admin/config/services/openstack/settings and post the random input data.

Issue fork cloud-3246044

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yutong.li created an issue. See original summary.

yutong.li credited yas.

yutong.li’s picture

yutong.li commented
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Related issues: +#3245650: Add test cases for K8s Admin Setting forms (Settings), +#3244513: Add test cases for Cloud Admin Setting forms (Settings), +#3232932: Refactor test cases for AWS Cloud Admin Setting forms, +#3245877: Add test cases for VMware Admin Setting forms (Settings)
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Parent issue: #3245877: Add test cases for VMware Admin Setting forms (Settings) »
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes

yutong.li opened merge request !488

yutong.li’s picture

yutong.li commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@yutong.li

Could you please fix the coding standard violation? https://www.drupal.org/pift-ci-job/2221433

Thanks!

yutong.li’s picture

yutong.li commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@yutong.li

Thank you for adding the test case. It looks good to me. I'll merge the patch to 4.x and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add test cases for OpenStack Admin Setting forms (Settings) » Add test cases for OpenStack Admin Setting forms (Settings)

  • yas committed 5b8b308 on 3.x authored by yutong.li 
    Issue #3246044 by yutong.li, yas:  Add test cases for OpenStack Admin...

  • yas committed 4f05aea on 4.x authored by yutong.li 
    Issue #3246044 by yutong.li, yas: Add test cases for OpenStack Admin...

yas closed merge request !488

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.