Problem/Motivation

Add test cases for K8s Admin Setting forms:

  • Drupal\Tests\cloud\Functional\Config\K8sAdminSettings::testK8sAdminSettings()

Specification:

  • Implement Drupal\Tests\k8s\Traits\K8sTestFormDataTrait\createK8sSettingsTestFormData() to return an array including the random input data for /admin/config/services/k8s/settings
  • Access (HTTP Get) /admin/config/services/k8s/settings and post the random input data.

Issue fork cloud-3245650

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yutong.li created an issue. See original summary.

yutong.li credited yas.

yutong.li’s picture

yutong.li commented
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Related issues: +#3246044: Add test cases for OpenStack Admin Setting forms (Settings), +#3245877: Add test cases for VMware Admin Setting forms (Settings), +#3232932: Refactor test cases for AWS Cloud Admin Setting forms, +#3245650: Add test cases for K8s Admin Setting forms (Settings)
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Related issues: -#3245650: Add test cases for K8s Admin Setting forms (Settings)
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Parent issue: #3244513: Add test cases for Cloud Admin Setting forms (Settings) »
Related issues: +#3244513: Add test cases for Cloud Admin Setting forms (Settings)
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes

yutong.li opened merge request !491

yutong.li opened merge request !492

yas closed merge request !492

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Active » Needs work
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add test cases for K8s Admin Setting forms (Settings) » Add test cases for K8s Admin Setting forms (Settings)

@yutong.li

Thank you for adding the test case. I found the issue in Drupal\k8s\Form\Config::K8sAdminSettings and I think I could fix it.

@xiaohua-guan

Could you please review the patch especially for K8sAdminSettings::submitForm()?

xiaohua guan’s picture

xiaohua guan commented

@yas

It looks good to me. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for your review. I'll merge the patch to 3.x and 4.x, and close this issue as Fixed.

  • yas committed 28d82fc on 4.x authored by yutong.li 
    Issue #3245650 by yutong.li, yas, Xiaohua Guan: Add test cases for K8s...

yas closed merge request !491

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

  • yas committed 0027abf on 3.x authored by yutong.li 
    Issue #3245650 by yutong.li, yas, Xiaohua Guan: Add test cases for K8s...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.