Problem/Motivation

Problem/Motivation

  • Fix the following inconsistent return points:
    • aws_cloud.module
    • cloud_cluster_worker.module
    • CloudConfigStorage.php
    • CloudDeleteMultipleFormTrait.php
    • CloudLaunchTemplateStorage.php
    • CloudProcessMultipleForm.php
    • CloudProjectDeleteMultipleForm.php
    • CloudProjectStorage.php 
    • CloudStoreDeleteMultipleForm.php
    • CloudStoreStorage.php
    • InstanceRebootMultipleForm.php
    • K8sCloudProjectPlugin.php
    • openstack.module
    • OpenStackFloatingIpDeleteMultipleForm.php
    • TextToSelectFilter.php
    • VmwareDeleteMultipleForm.php
    • VolumeDetachMultipleForm.php
CommentFileSizeAuthor
#10 3238990-10.patch17.64 KBxld
#8 3238990-8.patch17.68 KBxld
#5 3238990-5.patch14.69 KBxld
#3 3238990-3.patch6.21 KBxld

Issue fork cloud-3238990

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

XLD created an issue. See original summary.

XLD opened merge request !417

xld’s picture

xld commented
Status: Needs work » Needs review
StatusFileSize
new 3238990-3.patch6.21 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Needs work

@XLD

Thank you for fixing the issue. Could you please fix the following errors, too?

  • InstanceRebootMultipleForm.php
  • K8sCloudProjectPlugin.php
  • openstack.module
  • OpenStackFloatingIpDeleteMultipleForm.php
  • TextToSelectFilter.php
  • VmwareDeleteMultipleForm.php
  • VolumeDetachMultipleForm.php

Thanks

xld’s picture

xld commented
StatusFileSize
new 3238990-5.patch14.69 KB

@Yas, please review patch #5. I have fixed the inconsistent return types for all the mentioned classes.

xld’s picture

xld commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@XLD

Thank you for fixing the issue. Could you please fix a filename of 3232196-4.patch?
Also, Could you please fix the following errors, too?

  • openstack.module aws_cloud.module (aws_cloud_help())
  • openstack.module aws_cloud.module (aws_cloud_update_instance_types())

Thanks!

xld’s picture

xld commented
Status: Needs work » Needs review
StatusFileSize
new 3238990-8.patch17.68 KB

@Yas, done the changes. Sorry, I didn't notice that patch in the merge request. Removed it now.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Needs work

@XLD

Thank you for the update. I found one line comment to be removed. Please check my above comment. Thanks!

xld’s picture

xld commented
Status: Needs work » Needs review
StatusFileSize
new 3238990-10.patch17.64 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@XLD

Thank you for the update. It looks good to me now. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed d77ea96 on 4.x authored by XLD 
    Issue #3238990 by XLD, yas:  Fix inconsistent return points

yas closed merge request !417

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.