Acceptance Criteria:

Refactor a deprecated function drupal_get_path()

See also: https://www.drupal.org/node/2940438

drupal_get_path()

If you want to specify the type dynamically you can use:

drupal_get_path('module', 'node') -> \Drupal::service('extension.path.resolver')->getPath('module', 'node')

CommentFileSizeAuthor
#15 3227311-15.patch16.68 KBxld
#14 3227311-14.patch855 bytesxld
#13 3227311-13.patch779 bytesxld
#11 3227311-11.patch16.54 KBxld
#9 3227311-9.patch16.53 KBxld
#6 3227311-6.patch16.41 KBxld

Issue fork cloud-3227311

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

XLD created an issue. See original summary.

xld’s picture

xld commented
Issue summary: View changes

XLD opened merge request !342

xld’s picture

xld commented
Status: Active » Needs work
ankithashetty’s picture

ankithashetty
Location Karnataka, India
commented
Status: Needs work » Needs review

There is a MR to be reviewed in #3, so changing status to "Needs review", thanks!

xld’s picture

xld commented
StatusFileSize
new 3227311-6.patch16.41 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@XLD

Thank you for the refactoring. It looks good to me; I posted my comments above. Please check the ones. Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@XLD

Also, please fix a coding standard violation.

xld’s picture

xld commented
Status: Needs work » Needs review
StatusFileSize
new 3227311-9.patch16.53 KB

Status: Needs review » Needs work

The last submitted patch, 9: 3227311-9.patch, failed testing. View results

xld’s picture

xld commented
Status: Needs work » Needs review
StatusFileSize
new 3227311-11.patch16.54 KB

@Yas, To call the function in your proposed way in the Trait we need to create a constructor which is not entirely recommended for traits. I have uploaded the patch with the remaining changes but please review it and advise further. Thank you.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@XLD

Thank you for your update.

To call the function in your proposed way in the Trait we need to create a constructor which is not entirely recommended for traits.

Yes, I agree with you. Please put the comment as you said. Also, please rebase the branch.

Thanks!

xld’s picture

xld commented
Status: Needs work » Needs review
StatusFileSize
new 3227311-13.patch779 bytes
xld’s picture

xld commented
StatusFileSize
new 3227311-14.patch855 bytes

Updated patch after rebase.

xld’s picture

xld commented
StatusFileSize
new 3227311-15.patch16.68 KB
xld’s picture

xld commented
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@XLD

Thank you for the update. It looks good to me. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed 2a07fcd on 4.x authored by XLD 
    Issue #3227311 by XLD, yas: Refactor deprecated function drupal_get_path...

yas closed merge request !342

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.