Problem/Motivation

Add test cases for the validation of IAM permissions when editing a cloud service provider.

CommentFileSizeAuthor
#7 3217769-7.diff17.97 KBkumikoono
#4 3217769-4.diff17.13 KBkumikoono
#3 3217769-3.diff18.47 KBkumikoono

Issue fork cloud-3217769

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kumikoono created an issue. See original summary.

kumikoono opened merge request !246

kumikoono’s picture

kumikoono commented
Status: Active » Needs review
StatusFileSize
new 3217769-3.diff18.47 KB
  • Added test cases
kumikoono’s picture

kumikoono commented
StatusFileSize
new 3217769-4.diff17.13 KB

yas made their first commit to this issue’s fork.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@kumikoono

Thank you for adding the test cases. I posted my comments. Please check them. Thanks

kumikoono’s picture

kumikoono commented
StatusFileSize
new 3217769-7.diff17.97 KB
  • Added assertions for no unexpected errors, e.g., Drupal illegal choice error.
  • Incorporated your comments here.
kumikoono’s picture

kumikoono commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@kumikoono

Thank you for the update. It looks good now. I'll merge the patch to 3.x and close this issue as Fixed.

  • yas committed 7fbc2c4 on 3.x authored by kumikoono 
    Issue #3217769 by kumikoono, yas: Add test cases for the validation of...

yas closed merge request !246

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.