Problem/Motivation

When an AWS cloud context has edited with an incomplete set of required IAM permissions, a user finds the problem with IAM permissions on hitting some resource “Save” button after entering all the necessary information. This delayed timing of checking IAM permissions wastes the user's effort at filling out a lot of information, resulting in bad user experience.

Steps to reproduce

  1. Create a cloud service provider with a user having sufficient IAM permissions.
  2. Edit the cloud service provider by modifying the user having insufficient IAM permissions.

Proposed resolution

Validate IAM permissions on editing the existing cloud service provider.

CommentFileSizeAuthor
#12 hotfix-3210496-12.patch761 bytesyas
#6 3210496-6.patch1.38 KByas

Issue fork cloud-3210496

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kumikoono created an issue. See original summary.

kumikoono opened merge request !219

kumikoono’s picture

kumikoono commented
Status: Active » Needs review

Manually tested. Test cases to be added.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
baldwinlouie’s picture

baldwinlouie commented
Status: Needs work » Needs review

@kumikoono, @yas Thank you for the patch. It is fine to me.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3210496-6.patch1.38 KB

@baldwinlouie

Thank you for your review.

@kumikoono

Thank you for the update. Now it looks good, I'll merge the patch to 3.x and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@baldwinlouie

Thank you for your review.

@kumikoono

Thank you for the update. Now it looks good, I'll merge the patch to 3.x and close this issue as Fixed.

  • yas committed c21a072 on 3.x authored by kumikoono 
    Issue #3210496 by kumikoono, yas, baldwinlouie: Validate more IAM...

yas closed merge request !219

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

yas opened merge request !225

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Fixed » Needs review
StatusFileSize
new hotfix-3210496-12.patch761 bytes

@kumikoono

Fixing a coding standard violation.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@kumikoono

The tests have been passed successfully, I'll merge the patch to 3.x and close this issue as Fixed.

  • yas committed 6d11100 on 3.x 
    Issue #3210496 by yas: Hotfix - Validate more IAM permissions when...

yas closed merge request !225

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.