Problem/Motivation

  • Update composer.json for Drupal 9.1.x
CommentFileSizeAuthor
#68 3186209-68-3.x.patch5.99 KByas
#66 3186209-66-3.x.patch5.99 KByas
#65 3186209-65-3.x.patch1009 bytesyas
#58 3186209-58-4.x.patch2.63 KByas
#57 3186209-57.patch2.63 KByas
#54 3186209-54.patch1.93 KByas
#51 h2RYs5o - Imgur.png30.01 KBilgnerfagundes
#47 3186209-47.patch2.01 KByas
#44 3186209-44.patch34.59 KByas
#41 3186209-41.patch34.54 KByas
#36 3186209-36.patch35.14 KByas
#33 3186209-33.patch35.14 KByas
#29 3186209-29.patch18.32 KByas
#27 3186209-27.patch18.29 KByas
#25 3186209-23.patch4.39 KByas
#23 3186209-22.patch4.39 KByas
#22 3186209-21.patch2.27 KByas
#20 3186209-20.patch1.91 KByas
#19 3186209-19.patch1.93 KByas
#18 3186209-18.patch1.95 KByas
#17 3186209-17.patch1.91 KByas
#16 3186209-16.patch1.78 KByas
#15 3186209-15.patch1.5 KByas
#14 3186209-14.patch1.47 KByas
#13 3186209-13.patch1.42 KByas
#12 3186209-12.patch1.92 KByas
#11 3186209-11.patch1.72 KByas
#10 3186209-10.patch2.09 KByas
#9 3186209-9.patch2.09 KByas
#8 3186209-8.patch2.09 KByas
#7 3186209-7.patch1.72 KByas
#6 3186209-6.patch1.42 KByas
#5 3186209-5.patch1.79 KByas
#4 3186209-4.patch1.79 KByas
#3 3186209-3.patch1.2 KByas
#2 3186209-2.patch1.16 KByas

Issue fork cloud-3186209

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yas created an issue. See original summary.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Active » Needs review
StatusFileSize
new 3186209-2.patch1.16 KB

Let me try.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3186209-3.patch1.2 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3186209-4.patch1.79 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3186209-5.patch1.79 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3186209-6.patch1.42 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3186209-7.patch1.72 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3186209-8.patch2.09 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3186209-9.patch2.09 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3186209-10.patch2.09 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3186209-11.patch1.72 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3186209-12.patch1.92 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3186209-13.patch1.42 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3186209-14.patch1.47 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3186209-15.patch1.5 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3186209-16.patch1.78 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3186209-17.patch1.91 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3186209-18.patch1.95 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3186209-19.patch1.93 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3186209-20.patch1.91 KB

Status: Needs review » Needs work

The last submitted patch, 20: 3186209-20.patch, failed testing. View results

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3186209-21.patch2.27 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
StatusFileSize
new 3186209-22.patch4.39 KB

Status: Needs review » Needs work

The last submitted patch, 23: 3186209-22.patch, failed testing. View results

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
StatusFileSize
new 3186209-23.patch4.39 KB

Status: Needs review » Needs work

The last submitted patch, 25: 3186209-23.patch, failed testing. View results

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
StatusFileSize
new 3186209-27.patch18.29 KB

Status: Needs review » Needs work

The last submitted patch, 27: 3186209-27.patch, failed testing. View results

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3186209-29.patch18.32 KB

Fixing the coding standard violations.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
xiaohua guan’s picture

xiaohua guan commented

@yas

The patch looks good to me.

baldwinlouie’s picture

baldwinlouie commented

@yas, I have a question about the patch.

+++ b/cloud.info.yml
@@ -2,7 +2,7 @@ name: 'Cloud'
+core_version_requirement: ^9

Does this mean cloud module will only support Drupal 9+?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3186209-33.patch35.14 KB

@xiaohua-guan @baldwinlouie

Thank you for your review.

Does this mean cloud module will only support Drupal 9+?

Yes, that's a very good point. When we want to upgrade "maclof/kubernetes-client": "~0.17", (0.17 or higher), it is not compatible with Drupal 8.9.x. Here is the error:

  Problem 1
    - maclof/kubernetes-client[0.17.0, ..., 0.21.0] require symfony/yaml ~4.0|~5.0 -> found symfony/yaml[v4.0.0-BETA1, ..., 4.4.x-dev, v5.0.0-BETA1, ..., 5.x-dev] but the package is fixed to v3.4.41 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.
    - Root composer.json requires maclof/kubernetes-client ~0.17 -> satisfiable by maclof/kubernetes-client[0.17.0, ..., 0.21.0].

D9+ looks compatible with those symfony libraries. Therefore if we upgrade maclof/kubernetes-client, we need to drop Drupal 8.x

At this point, this composer.json is our golden combination to support Drupal 9.1.x or higher.

However... on my second thoughts, we should apply this patch to 4.x to be created when we release 3.0.0. What do you think?

PS I refactored the patch.

Status: Needs review » Needs work

The last submitted patch, 33: 3186209-33.patch, failed testing. View results

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3186209-36.patch35.14 KB

Status: Needs review » Needs work

The last submitted patch, 36: 3186209-36.patch, failed testing. View results

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Related issues: +#3186443: PHPUnit 9.5 Call to undefined method ::getAnnotations()

@baldwinlouie @xiaohua-guan

Suddenly the tests started to fail; looks due to the problem in Drupal Core: PHPUnit 9.5 Call to undefined method ::getAnnotations()

baldwinlouie’s picture

baldwinlouie commented

@yas, thank you for the explanation. I was thinking how best to support Drupal 8 and Drupal 9. When I read this: https://www.drupal.org/docs/understanding-drupal/drupal-9-release-date-a..., it states Drupal 8 will be supported until November 2, 2021. But importantly, it states only patches and security releases will make it into Drupal 8. No new features.

For our module, I like your idea of dropping Drupal 8 support in the 4.x branch. I think it is a bit sudden to drop Drupal 8 support right before a stable 3.x release.

That way, it is a clean break when we start working on 4.x

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Reviewed & tested by the community

@baldwinlouie

Thank you for your comment and the link. Let's keep supporting Drupal 8 and drop it in the 4.x branch.

They fixed the issue quickly, so this patch should be ready. Let's keep RTBC status w/o merging this patch until we start to develop 4.x branch.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3186209-41.patch34.54 KB

Updated the patch for the recent merges.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 41: 3186209-41.patch, failed testing. View results

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Reviewed & tested by the community
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3186209-44.patch34.59 KB

Updated the patch.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 44: 3186209-44.patch, failed testing. View results

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Reviewed & tested by the community
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Related issues: +#3190294: Fix CloudServerTemplatePlugins for Drupal 9.2.x
StatusFileSize
new 3186209-47.patch2.01 KB

Removing AwsCloudServerTemplatePlugin and K8sCloudServerTemplatePlugin fixes since those fixes are included in the patch at #3190294

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 47: 3186209-47.patch, failed testing. View results

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Reviewed & tested by the community
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Related issues: +#3195065: Upgrade maclof/kuberntes library to the latest (0.21.0)
ilgnerfagundes’s picture

ilgnerfagundes commented
StatusFileSize
new h2RYs5o - Imgur.png30.01 KB

I applied patch # 47 it applies correctly. For me everything is correct, rtbc +1

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@ilgnerfagundes

Thank you for your help. As I mentioned in #3195065, we have our upgrade plan. We will include this patch into our drupal/cloud:4.x branch when we create it soon.

yas opened merge request !252

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3186209-54.patch1.93 KB

@all

Updated the patch due to the merge at #3218796: Update composer.json to release 3.0.0

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Related issues: +#3218796: Update composer.json to release 3.0.0
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3186209-57.patch2.63 KB

Updating the patch file. Thanks to @xiaohua-guan, we are fixing the issue on Drupal 9.2.x.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Update composer.json for Drupal 9.1.x » Update composer.json for Drupal 9.2.x
Version: 3.x-dev » 4.x-dev
StatusFileSize
new 3186209-58-4.x.patch2.63 KB

Adding a patch for the 4.x branch

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@xiaohua-guan @baldwinlouie

The tests have been passed successfully on Drupal 9.2.x, so I'll merge the patch at #3186209-58: Update composer.json for Drupal 9.2.x to 4.x and close this issue as Fixed.

  • yas committed 590a200 on 4.x 
    Issue #3186209 by yas, Xiaohua Guan, baldwinlouie, ilgnerfagundes:...

yas closed merge request !252

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Closed (fixed) » Needs work

Re-opening this issue since we need to apply the patch.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
StatusFileSize
new 3186209-65-3.x.patch1009 bytes
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3186209-66-3.x.patch5.99 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community
Related issues: +#3228688: Release 3.0.2

@all

The tests have been passed successfully, so I'll merge the patch to 3.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3186209-68-3.x.patch5.99 KB

  • yas committed 34e5bbe on 3.x 
    Issue #3186209 by yas, ilgnerfagundes, baldwinlouie, Xiaohua Guan:...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.