Problem/Motivation

Upgrade maclof/kuberntes library to the latest (0.21.0)

Also fix the API compatibility for the latest version of maclof/kubernetes client library (K8sClient::sendRequrest()).

CommentFileSizeAuthor
#14 3195065-14-4.x.patch4.27 KByas
#10 3195065-9.patch4.27 KBxiaohua guan
#6 K0kGMUo - Imgur.png117.1 KBilgnerfagundes
#3 3195065-3.patch3.99 KBxiaohua guan

Issue fork cloud-3195065

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Xiaohua Guan created an issue. See original summary.

xiaohua guan’s picture

xiaohua guan commented
Issue summary: View changes
xiaohua guan’s picture

xiaohua guan commented
Status: Active » Needs review
StatusFileSize
new 3195065-3.patch3.99 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for the refactoring. It looks good however the patch contains composer.json change therefore let us try to merge the patch after creating a drupal/cloud:4.x branch.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Related issues: +#3186209: Update composer.json for Drupal 9.2.x
ilgnerfagundes’s picture

ilgnerfagundes commented
StatusFileSize
new K0kGMUo - Imgur.png117.1 KB

I applied patch #3 it applies correctly. For me everything is correct, rtbc +1

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@ilgnerfagundes

Thank you for your test. We are pending this MR until we release drupal/cloud:3.0.0. The drupal/cloud:3.0.0 is hopefully coming soon and after releasing 3.0.0, then we'll create a drupal/cloud:4.x branch and include this patch into drupal/cloud:4.x.

We need to sync-up with our library upgrade with Drupal core in between 9.0 and 9.1 or higher. We have tested our library upgrade and already found that we needed to have some upgrade plan. Thank you for your patient.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work

@xiaohua-guan

The patch is now behind against HEAD. Could you please rebase and resolve the conflicts? I'll change the status to Needs work. Thanks

Xiaohua Guan opened merge request !261

xiaohua guan’s picture

xiaohua guan commented
StatusFileSize
new 3195065-9.patch4.27 KB
xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review
xiaohua guan’s picture

xiaohua guan commented

@yas

I've rebased the code. Please take a look. Thanks.

xiaohua guan’s picture

xiaohua guan commented

@yas

I rebased the code. Please check the merge request. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Version: 3.x-dev » 4.x-dev
StatusFileSize
new 3195065-14-4.x.patch4.27 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for the rebase and update of the patch. The tests have been passed successfully, so I'll merge the patch to 4.x and close this issue as Fixed. Thanks!

  • yas committed cba1094 on 4.x authored by Xiaohua Guan 
    Issue #3195065 by Xiaohua Guan, yas, ilgnerfagundes: Upgrade maclof/...

yas closed merge request !261

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.