CommentFileSizeAuthor
#5 interdiff-3167439-5.txt1.53 KBjigish.addweb
#5 3167439-5.patch55.74 KBjigish.addweb
#2 3167439-2.patch55.74 KBjigish.addweb

Comments

jigish.addweb created an issue. See original summary.

jigish.addweb’s picture

jigish.addweb commented
Issue summary: View changes
StatusFileSize
new 3167439-2.patch55.74 KB
jigish.addweb’s picture

jigish.addweb commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work 
+++ b/modules/cloud_service_providers/openstack/tests/src/Traits/OpenStackTestEntityTrait.php
@@ -16,6 +17,32 @@ trait OpenStackTestEntityTrait {
+      'type'                    => 'openstack',
+      'cloud_context'           => $cloud_context,
+      'label'                   => "Amazon EC2 US West ($num) - {$random->name(8, TRUE)}",
+      'field_os_region'            => 'RegionOne',
+      'field_access_key'        => $random->name(20, TRUE),
+      'field_secret_key'        => $random->name(40, TRUE),
+      'field_api_endpoint'  => "https://ec2.us-west-${num}.amazonaws.com",
+      'field_image_upload_url'  => "https://ec2.us-west-${num}.amazonaws.com",

This is my cosmetic concern about the source code --- Let's align the format of 'key' = $value to the longest key, which is field_image_upload_url' => "https://ec2.us-west-${num}.amazonaws.com", Note that 'field_image_upload_url' should be 'field_image_upload_url' => "https://ec2.us-west-${num}.amazonaws.com", removing redundant extra one space.

jigish.addweb’s picture

jigish.addweb commented
StatusFileSize
new 3167439-5.patch55.74 KB
new interdiff-3167439-5.txt1.53 KB
jigish.addweb’s picture

jigish.addweb commented
Status: Needs work » Needs review

@yas Thank you for your review.

I have done changes as per your comment. Please review the updated patch.

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@jigishaddweb

Thank you for the update. It looks good to me. I'll merge the patch to 8.x-2.x and 3.x and close this issue as Fixed.

  • yas committed 789d1d5 on 8.x-2.x authored by jigish.addweb 
    Issue #3167439 by jigish.addweb, yas: Add test cases for Refresh buttons...

  • yas committed ef54103 on 3.x authored by jigish.addweb 
    Issue #3167439 by jigish.addweb, yas: Add test cases for Refresh buttons...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.