Closed (fixed)
Project:
Cloud
Version:
8.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
16 Mar 2020 at 05:33 UTC
Updated:
3 Apr 2020 at 04:59 UTC
Jump to comment: Most recent, Most recent file
cloud, aws_cloud, k8s and openstack| Comment | File | Size | Author |
|---|---|---|---|
| #12 | 3119973-12.patch | 116.01 KB | yas |
Comments
Comment #2
yasCloudModuleTestBaseAwsCloudInstallUninstallTestCloudBudgetInstallUninstallTestK8sInstallUninstallTestOpenStackInstallUninstallTestCloudInstallUninstallTesthook_helpfor the modules:cloudaws_cloudk8sopenstackComment #3
yasFixing the coding standard violation.
Comment #4
yasUpdated.
Comment #5
baldwinlouie commented@yas, I have the following comments about this patch.
Does this function need a try/catch block?
This function might change depending on the status of https://www.drupal.org/project/cloud/issues/3120163
This might need to change depending on
https://www.drupal.org/project/cloud/issues/3120163
aws_cloud_config js library has been removed. I don't know if this attach is needed anymore.
Comment #6
yas@baldwinlouie
Thank you for your review. I just updated the patch to fix 1. and 4. I didn't fix 2. 3.
Comment #7
yas@baldwinlouie
I re-created the patch after merging #3120163. #3115078 and #3119979. Could you please review it again?
Comment #8
yasThe test result:
Comment #9
yasUpdated the patch.
Comment #10
baldwinlouie commented@yas, Thank you for the updated patch. I have the following comments.
K8s and OpenStack should have an update function that updates the default icon.
`field termination` should be `field_launch_resources`
Comment #11
yas@baldwinlouie
Thank for your review.
K8sandOpenStacksince those are no change for the filename such ask8s.pngandopenstack.png. I aligned the default icon filename is equals to module name. Therefore foraws_cloud, I changed the icon name from aws.png toaws_cloud.png; that's why I putaws_cloud_update_8219to address this change.Moreover, I added the install/uninstall test for the other modules such as
Drupal\Tests\docker\Functional\Module\DockerInstallUninstallTestDrupal\Tests\gapps\Functional\Module\GAppsInstallUninstallTestDrupal\Tests\k8s_to_s3\Functional\Module\K8sToS3InstallUninstallTestDrupal\Tests\s3_to_k8s\Functional\Module\S3ToK8sInstallUninstallTestHere is the test results:
Could you please review it?
Comment #12
yasFixed the coding standard violations.
Comment #13
baldwinlouie commented@yas, thank you for the updated patch. It looks good to me now.
Comment #14
yas@baldwinlouie
Thank you for your review. I'll merge the patch to
8.x-1.xand8.x-2.xand close this issue asFixed.Comment #17
yas