• Refactor <module>_add_default_icon to cloud_add_default_icon
CommentFileSizeAuthor
#7 interdiff-3120163-7.txt1.55 KByas
#7 3120163-7.patch6.34 KByas
#3 3120163-3.patch6.29 KByas
#2 3120163-2.patch24.23 KByas

Comments

yas created an issue. See original summary.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
StatusFileSize
new 3120163-2.patch24.23 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3120163-3.patch6.29 KB
baldwinlouie’s picture

baldwinlouie commented
Status: Needs review » Reviewed & tested by the community

@yas, This patch looks good!

baldwinlouie’s picture

baldwinlouie commented
Status: Reviewed & tested by the community » Needs review
baldwinlouie’s picture

baldwinlouie commented
Status: Needs review » Needs work

@yas, sorry, I found an issue with the patch. Please take a look at the comments below,

  1. +++ b/modules/cloud_service_providers/aws_cloud/aws_cloud.install
@@ -23,7 +22,7 @@ use Drupal\field\Entity\FieldStorageConfig;
+  cloud_add_default_icon();

    The function call is missing the $module parameter 

  2. +++ b/modules/cloud_service_providers/aws_cloud/aws_cloud.install
@@ -1772,7 +1747,7 @@ function aws_cloud_update_8193() {
+  cloud_add_default_icon();

    The function call is missing the $module parameter 

  3. +++ b/modules/cloud_service_providers/k8s/k8s.install
@@ -14,7 +13,7 @@ use Drupal\Core\Field\FieldStorageDefinitionInterface;
+  cloud_add_default_icon();

    The function call is missing the $module parameter 

  4. +++ b/modules/cloud_service_providers/k8s/k8s.install
@@ -989,7 +988,7 @@ function k8s_update_8241() {
+  cloud_add_default_icon();

    The function call is missing the $module parameter 

  5. +++ b/modules/cloud_service_providers/openstack/openstack.install
@@ -12,7 +12,7 @@ use Drupal\Core\File\FileSystemInterface;
+  cloud_add_default_icon();

    The function call is missing the $module parameter

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
StatusFileSize
new 3120163-7.patch6.34 KB
new interdiff-3120163-7.txt1.55 KB

@baldwinlouie

Thank you so much for your review. I just updated the patch. Could you please review it again?

baldwinlouie’s picture

baldwinlouie commented
Status: Needs review » Reviewed & tested by the community

@yas, Thank you for the patch. This looks good.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@baldwinlouie

Thank you for your review. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.

  • yas committed 8d444a7 on 8.x-1.x 
    Issue #3120163 by yas, baldwinlouie: Refactor <module>_add_default_icon...

  • yas committed 2c11f5a on 8.x-2.x 
    Issue #3120163 by yas, baldwinlouie: Refactor <module>_add_default_icon...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.