Run through and fix the coder messages.

CommentFileSizeAuthor
#5 3052935-1.patch132.48 KBbaldwinlouie
#2 3052935.patch126.64 KBbaldwinlouie

Comments

baldwinlouie created an issue. See original summary.

baldwinlouie’s picture

baldwinlouie commented
Status: Active » Needs review
StatusFileSize
new 3052935.patch126.64 KB

Here's the first patch.

baldwinlouie’s picture

baldwinlouie commented

Regarding the patch above, I'm skipping the cloud.css file messages for now. We don't use those classes in the 8.x version. However, I don't want to remove that file just yet. It is a good reference if we ever want to bring it back. But I imagine it would exist in a a new subtheme and not at the module level.

To fix all of the coder messages, I ran the local version of Coder as described here: https://www.drupal.org/project/coder .

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@baldwinlouie

Thank you for the great patch. I agree to your thoughts. You can delete the cloud.css file; I'll put it into a new subtheme as a reference.

baldwinlouie’s picture

baldwinlouie commented
StatusFileSize
new 3052935-1.patch132.48 KB

@yas, here's an updated patch with cloud.css removed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@baldwinlouie

Thank you for deleting the cloud.css. I move that css file to https://git.drupalcode.org/sandbox/yas-3052571

@xiaohua-guan
@masami

What do you think?

baldwinlouie’s picture

baldwinlouie commented

@yas, If we check this in, we should run the module through https://pareview.sh/ to see if I missed any. I can go back in and fix anything I missed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@baldwinlouie

Yes, I'll do it

xiaohua guan’s picture

xiaohua guan commented

@baldwinlouie @yas

Thanks for the great patch file. It is ok to me.

masami’s picture

masami commented
Status: Needs review » Reviewed & tested by the community

@all
The patch looks good.
So I change the status to RTBC.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@xiaohua-guan
@masami

Thank you for your review. Then, I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.

  • yas committed 06b0043 on 8.x-1.x authored by baldwinlouie 
    Issue #3052935 by baldwinlouie, yas, Xiaohua Guan, Masami: Fix all the...

  • yas committed 19fa336 on 8.x-2.x authored by baldwinlouie 
    Issue #3052935 by baldwinlouie, yas, Xiaohua Guan, Masami: Fix all the...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
baldwinlouie’s picture

baldwinlouie commented

@yas, looks like we got all the php related issues. There are some complaints about javascript:

https://pareview.sh/pareview/https-git.drupal.org-project-cloud-8.x-1.x

Those look like javascript files that are not in use anymore. Maybe we open another issue to remove them?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@baldwinloue

Thank you for checking the cider online. Yes, we should create another issue to remove the old JavaScript files.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.